Closed
Bug 590048
Opened 14 years ago
Closed 14 years ago
Investigate and remove the 1000ms sleep in waitForPageLoad
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Keywords: regression, Whiteboard: [mozmill-1.5.1+][fixed by bug 602040])
With my patch on bug 503277 I have accidentally checked in a sleep call of 1000ms after we return from the waitFor function:
+ try {
+ // Wait until the page has been loaded
+ this.waitFor(function() { return self.loaded; }, aTimeout, aInterval);
+ this.sleep(1000);
This sleep call should not be necessary, at least not with 1000ms. Right now it slows down our testing for each page load and will be more visible once we have moved all the external content to local test pages.
We should investigate if we can completely remove this call or how much we can reduce the interval.
Assignee | ||
Updated•14 years ago
|
Whiteboard: [mozmill-1.4.3?] → [mozmill-1.5.1?]
Need to do a test run before and after this change to ensure we're ok, but we should take this for 1.5.1 if nothing breaks when we take it out. if anything breaks, we'll lump this into 1.5.2
Whiteboard: [mozmill-1.5.1?] → [mozmill-1.5.1+]
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Whiteboard: [mozmill-1.5.1+] → [mozmill-1.5.1+][will be fixed by bug 602040]
Assignee | ||
Comment 2•14 years ago
|
||
The timeout can safely removed for normal pages and should only take place for error pages. Those do not propagate the readyState=complete and we do not know when the DOM will be ready. But 1s should be more than enough. I can't see any new failures for test-runs but we are 100% faster with that change! Will be fixed with my patch on bug 602040.
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [mozmill-1.5.1+][will be fixed by bug 602040] → [mozmill-1.5.1+][fixed by bug 602040]
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•