Closed
Bug 590072
Opened 14 years ago
Closed 14 years ago
XP specific styling of menu buttons in popup notifications
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Terepin, Assigned: Margaret)
References
Details
Attachments
(3 files, 1 obsolete file)
|
(deleted),
image/png
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
Windows XP Arrow Panel Design
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100823 Minefield/4.0b5pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100823 Minefield/4.0b5pre
Someone from UX team should post a mockup.
Reproducible: Always
|
||
Comment 1•14 years ago
|
||
|
|
||
Updated•14 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → margaret.leibovic
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #488046 -
Flags: review?(dao)
|
|
Assignee | |
Comment 3•14 years ago
|
||
|
||
Updated•14 years ago
|
Summary: XP specific styling of Doorhanger → XP specific styling of menu buttons in popup notifications
|
|
Assignee | |
Comment 4•14 years ago
|
||
(In reply to comment #2)
> Created attachment 488046 [details] [diff] [review]
> patch
Note: I built this patch on top of the patch for bug 577928.
Depends on: 577928
Whiteboard: [needs review dao]
|
|
||
Comment 5•14 years ago
|
||
Comment on attachment 488046 [details] [diff] [review]
patch
>diff --git a/toolkit/themes/winstripe/global/notification.css b/toolkit/themes/winstripe/global/notification.css
>--- a/toolkit/themes/winstripe/global/notification.css
>+++ b/toolkit/themes/winstripe/global/notification.css
>@@ -58,68 +58,90 @@ notification[type="critical"] .messageIm
> }
>
> /* Popup notification button */
>
> .popup-notification-menubutton {
> margin-top: 17px;
> }
>
>-%ifdef WINSTRIPE_AERO
Use %ifdef XP_WIN here, since winstripe is the basis for various non-Windows toolkit themes.
Attachment #488046 -
Flags: review?(dao) → review+
|
|
||
Updated•14 years ago
|
Component: Theme → Themes
Product: Firefox → Toolkit
QA Contact: theme → themes
|
|
Assignee | |
Comment 6•14 years ago
|
||
Attachment #488046 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Attachment #488055 -
Flags: approval2.0?
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs review dao] → [can land]
|
||
Updated•14 years ago
|
Attachment #488055 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 7•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [can land]
You need to log in
before you can comment on or make changes to this bug.
Description
•