Ginn Chen Assignee
	Description • 14 years ago

"/export/home/moz/tools/ff_slave/mozilla-central-solaris-x86/build/netwerk/test/TestSTSParser.cpp", line 80: Error: Trailing comma in a parameter list.
"/export/home/moz/tools/ff_slave/mozilla-central-solaris-x86/build/netwerk/test/TestSTSParser.cpp", line 87: Error: Trailing comma in a parameter list.
"/export/home/moz/tools/ff_slave/mozilla-central-solaris-x86/build/netwerk/test/TestSTSParser.cpp", line 89: Error: Trailing comma in a parameter list.
"/export/home/moz/tools/ff_slave/mozilla-central-solaris-x86/build/netwerk/test/TestSTSParser.cpp", line 102: Error: Trailing comma in a parameter list.

Quotation from
http://forums.sun.com/thread.jspa?messageID=9367375#9367375

The C99 Standard says in the "Constraints" part of section 6.10.3, "there shall be more arguments in the invocation than there are parameters in the macro definition (excluding the ...)."

You can have a fixed argument in the macro definition
#define debug(arg1, ...) <something>
but you must have at least 2 arguments in each invocation.

if you want to be able to invoke the macro with one argument, the macro definition cannot have any fixed arguments.

	Sid Stamm [:geekboy or :sstamm]
	Comment 2 • 14 years ago

Comment on attachment 468969 [details] [diff] [review]
patch

Thanks for catching that, fix looks good.

	Ginn Chen Assignee
	Comment 3 • 14 years ago

The previous patch breaks gcc 4.3.
Should change ##__VA_ARGS__ to __VA_ARGS__.

	Sid Stamm [:geekboy or :sstamm]
	Comment 4 • 14 years ago

Comment on attachment 469418 [details] [diff] [review]
patch v2

Confirmed works just fine with GCC 4.3.

	Ginn Chen Assignee
	Comment 5 • 14 years ago

http://hg.mozilla.org/mozilla-central/rev/8f5523c9a830