Closed
Bug 590749
Opened 14 years ago
Closed 14 years ago
JM: jsreftest shell regressions from JM rev 35fed487745d
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: dmandelin, Assigned: dmandelin)
References
Details
Attachments
(1 file)
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
This rev caused 6 regressions on shell jsreftest only:
e4x\decompilation\regress-429249.js
ecma\extensions\trapflatclosure.js
js1_7\decompilation\regress-429252.js
js1_5\extensions\regress-431428.js
js1_5\extensions\regress-429264.js
js1_5\extensions\regress-422137.js
Assignee | ||
Comment 1•14 years ago
|
||
The recompiler wants to call ReleaseScriptCode to invalidate a script. This used to set script->execPool to NULL, which told us that the script had no compiled code, so we don't need to free that stuff again. With the regressing changeset, script->jit now indicates jit-code is present, but it is not nulled by ReleaseScriptCode. So we go ahead and try to free its member fields, which are garbage.
The fix just nulls out script->jit again.
Updated•14 years ago
|
Attachment #469261 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 2•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•