Closed Bug 590749 Opened 14 years ago Closed 14 years ago

JM: jsreftest shell regressions from JM rev 35fed487745d

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dmandelin, Assigned: dmandelin)

References

Details

Attachments

(1 file)

This rev caused 6 regressions on shell jsreftest only: e4x\decompilation\regress-429249.js ecma\extensions\trapflatclosure.js js1_7\decompilation\regress-429252.js js1_5\extensions\regress-431428.js js1_5\extensions\regress-429264.js js1_5\extensions\regress-422137.js
Attached patch Patch (deleted) — Splinter Review
The recompiler wants to call ReleaseScriptCode to invalidate a script. This used to set script->execPool to NULL, which told us that the script had no compiled code, so we don't need to free that stuff again. With the regressing changeset, script->jit now indicates jit-code is present, but it is not nulled by ReleaseScriptCode. So we go ahead and try to free its member fields, which are garbage. The fix just nulls out script->jit again.
Assignee: general → dmandelin
Status: NEW → ASSIGNED
Attachment #469261 - Flags: review?(dvander)
Attachment #469261 - Flags: review?(dvander) → review+
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: