Closed
Bug 591103
Opened 14 years ago
Closed 14 years ago
use TTL for history, form history, clients, tabs
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | betaN+ |
People
(Reporter: mconnor, Assigned: philikon)
References
Details
(Whiteboard: [has patch][has review][softblocker])
Attachments
(3 files, 3 obsolete files)
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
probably needs to be exposed as a property for engines, defaulting to never expire.
Assignee | ||
Comment 1•14 years ago
|
||
Probably best to hang this off the type records as they are the ones that know how to JSONify themselves to a WBO (which would include the TTL information).
Assignee | ||
Comment 2•14 years ago
|
||
We haven't officially documented the TTL stuff yet, but as far as I can tell, it's a numeric attribute of the WBO called 'ttl' expressing a UNIX timestamp (seconds) of when the object expires. Absence or a value >= 2100000000 means it lives forever.
History entries TTLs should live for 30 days from their last modification. What values do we want for form history and clients/tabs?
Assignee | ||
Updated•14 years ago
|
blocking2.0: --- → ?
Reporter | ||
Comment 4•14 years ago
|
||
This is needed so quotas don't completely suck.
blocking2.0: ? → beta9+
OS: Mac OS X → All
Hardware: x86 → All
Would this really hold a time-based released? Why can't it wait for the next beta? Moving to betaN
blocking2.0: beta9+ → betaN+
Assignee | ||
Comment 6•14 years ago
|
||
Make WBO sane and more unit-y:
* don't test HTTP auth at the same time
* use fetch() method if we're talking over the wire at all
* move common HTTP test helper to head file
* clean up unnecessary do_throw() calls
* use common helpers for test logging
Assignee | ||
Comment 7•14 years ago
|
||
Add a TTL property to WBOs. If engine record implementations have a 'ttl' attribute, it gets included in the WBO. Add default TTLs:
* clients: 7 days
* tabs: 7 days
* history: 30 days
In part 2 (TBD) the client engine will need to make sure to update its server record at least once a week.
Attachment #502431 -
Flags: review?(mconnor)
Assignee | ||
Updated•14 years ago
|
Whiteboard: [has wip]
Assignee | ||
Comment 8•14 years ago
|
||
Use a TTL of 21 days for client records.
Attachment #502431 -
Attachment is obsolete: true
Attachment #502950 -
Flags: review?(mconnor)
Attachment #502431 -
Flags: review?(mconnor)
Assignee | ||
Comment 9•14 years ago
|
||
The TTL for client records is 21 days so we make sure that we upload a new client record every 7 days.
Attachment #502951 -
Flags: review?(mconnor)
Assignee | ||
Updated•14 years ago
|
Whiteboard: [has wip] → [has patch][needs review mconnor]
Reporter | ||
Updated•14 years ago
|
Attachment #502430 -
Flags: review?(mconnor) → review+
Updated•14 years ago
|
Whiteboard: [has patch][needs review mconnor] → [has patch][needs review mconnor][softblocker]
Reporter | ||
Comment 10•14 years ago
|
||
Comment on attachment 502950 [details] [diff] [review]
Part 1 (v1.1): Add ttl property to WBOs
> ClientsRec.prototype = {
> __proto__: CryptoWrapper.prototype,
> _logName: "Record.Clients",
>+ // 21 days
>+ ttl: 1814400
Error: Magic number detected. 3 additional copies of this error reported.
(Please make these consts, since I suspect we'll tune these values at some point.)
We'll probably want a crossweave test for this at some point.
Attachment #502950 -
Flags: review?(mconnor) → review+
Reporter | ||
Comment 11•14 years ago
|
||
Comment on attachment 502951 [details] [diff] [review]
Part 2 (v1): Clients engine needs to periodically upload new record
>+ _syncStartup: function _syncStartup() {
>+ // Reupload new client record after 7 days.
>+ if (Date.now() / 1000 - this.lastRecordUpload > 604800) {
another magic number. I thought i raised you better than that.
Attachment #502951 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 12•14 years ago
|
||
Incorporate review comment: move numbers to consts.
Attachment #502950 -
Attachment is obsolete: true
Assignee | ||
Comment 13•14 years ago
|
||
Incorporate review comment: move numbers to consts.
Attachment #503684 -
Attachment is obsolete: true
Assignee | ||
Comment 14•14 years ago
|
||
There was IRC talk about having history TTLs of 60 days rather than 30 days. Can we get a decision on this?
Other than that this is ready for landing.
Whiteboard: [has patch][needs review mconnor][softblocker] → [has patch][has review][softblocker]
Reporter | ||
Comment 15•14 years ago
|
||
We're going to go with 60 days to start. Ship it!
Assignee | ||
Comment 16•14 years ago
|
||
1.6.x:
Part 0: https://hg.mozilla.org/services/fx-sync/rev/5289b58f2c4a
Part 1: https://hg.mozilla.org/services/fx-sync/rev/b8d357f848c4
Part 2: https://hg.mozilla.org/services/fx-sync/rev/23dc83bca24e
default:
Part 0: https://hg.mozilla.org/services/fx-sync/rev/7e64c61313be
Part 1: https://hg.mozilla.org/services/fx-sync/rev/3701ffdc6c0e
Part 2: https://hg.mozilla.org/services/fx-sync/rev/4ca4c048cbb9
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 17•14 years ago
|
||
Backed out from 1.6.x, was not meant to go there: https://hg.mozilla.org/services/fx-sync/rev/e34a3410f235
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•