Right now (beta 4) Tab Candy's snapping system will only snap a group item to the edge of another one if the dragged group item's bounds are contained with the "active range" of the other (stationary) group's trench (aka "snapping zone"). For example, in beta 4, the following group being dragged would not snap: http://img.skitch.com/20100827-edq5r6fuiu48jsatyfetxb6myt.jpg In earlier versions of TabCandy, this was working the way I believe it should: based on overlap, not containment. At some point prior to beta 4, I believe this behavior changed. I think we should take it back.

Aza, please ok this behavior change so we can get this reviewed and approved.

Reviewed and accepted.

Requesting blocking for beta 6.

nice interaction polish, but not something we'd hold the whole release for, so blocking-.

Comment on attachment 469770 [details] [diff] [review] Proposed patch nit: name the function, so that it shows up properly in debuggers. r+a=me with that change.

And backed out due to Moth test failures.

Note that bug 591705 was the culprit for failing mochitests on jdm's checking. However, we need a mochitest for this before we can land it.

I'm going to send m-c with this patch to try now to make sure tests pass.

Comment on attachment 472522 [details] [diff] [review] Patch with test, as well as quick mod to dragdrop test to make it more robust r=me, looks great, thanks!

Will push to try before requesting commit

verified on recent nightly builds of minefield