Closed
Bug 591816
Opened 14 years ago
Closed 14 years ago
Add tests for TabEngine
Categories
(Firefox :: Sync, enhancement)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
People
(Reporter: eric.lemoine, Assigned: eric.lemoine)
References
Details
(Whiteboard: [qa-])
Attachments
(5 files)
|
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:2.0b5pre) Gecko/20100828 Firefox/4.0b5pre
Build Identifier:
We need unit tests for TabEngine, TabStore, and TabTracker.
Reproducible: Always
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #470530 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #471032 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #471061 -
Flags: review?(mconnor)
|
||
Updated•14 years ago
|
Attachment #470530 -
Flags: review?(mconnor) → review+
|
|
||
Updated•14 years ago
|
Assignee: nobody → eric.lemoine
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: x86 → All
|
|
||
Comment 4•14 years ago
|
||
Comment on attachment 471032 [details] [diff] [review]
tests for TabEngine
>diff --git a/services/sync/tests/unit/test_tab_engine.js b/services/sync/tests/unit/test_tab_engine.js
>+function fakeSessionSvc() {
>+ let tabs = [];
>+ for(let i = 0; i<arguments.length; i++) {
style nit: spaces (before ( and on either side of < )
Attachment #471032 -
Flags: review?(mconnor) → review+
|
|
||
Updated•14 years ago
|
Attachment #471061 -
Flags: review?(mconnor) → review+
|
||
Comment 5•14 years ago
|
||
Fix to run in m-c's xpcshell harness
|
|
||
Comment 6•14 years ago
|
||
Fix to run in m-c's xpcshell harness
|
|
||
Comment 7•14 years ago
|
||
http://hg.mozilla.org/services/fx-sync/rev/7862132401c0
http://hg.mozilla.org/services/fx-sync/rev/44ed3e13cbd7
http://hg.mozilla.org/services/fx-sync/rev/34443b23582a
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Whiteboard: [qa-]
|
||
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•