Closed
Bug 592424
Opened 14 years ago
Closed 12 years ago
NS_STATE_ACCELTEXT_IS_DERIVED is never removed once set
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: Gavin, Unassigned)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
The code intends to remove it, but doesn't, because of a mistake in one of the patches for bug 190735.
Reporter | ||
Comment 1•14 years ago
|
||
Change in question:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/layout/xul/base/src&command=DIFF_FRAMESET&file=nsMenuFrame.cpp&rev2=1.251&rev1=1.250
(search for "someone reset the accelText attribute")
Reporter | ||
Comment 2•14 years ago
|
||
This makes it impossible to change a menuitem's acceltext after it's been set at frame construction time, since the attribute changed handler calls BuildAcceleratorText, which doesn't hit the short circuit check for non-derived non-blank values, and therefore clobbers the set value.
Reporter | ||
Comment 3•14 years ago
|
||
test_bug511075 is causing some kind of interference with the test when run in batch-mode (as opposed to individually) - need to investigate that further.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Reporter | ||
Comment 4•14 years ago
|
||
Attachment #471143 -
Attachment is obsolete: true
Reporter | ||
Comment 5•14 years ago
|
||
I'm also changing the behavior slightly, to allow removing the accelText entirely (i.e. setting to "") - useful for bug 589139. The old code overrides if the attribute is empty/nonexistent - the new code allows setting to "", and requires removing the attribute to have it be reset by BuildAcceleratorText().
Updated•14 years ago
|
Updated•14 years ago
|
status1.9.1:
--- → ?
status1.9.2:
--- → ?
Reporter | ||
Updated•14 years ago
|
blocking2.0: ? → ---
status1.9.1:
? → ---
status1.9.2:
? → ---
No longer depends on: 583957
Whiteboard: [patchlove]
Reporter | ||
Comment 6•14 years ago
|
||
Fixed by bug 630830 (http://hg.mozilla.org/mozilla-central/rev/561a1d421cec), but I probably want to spin off a bug for the behavior change because I think that'd be useful.
Reporter | ||
Comment 7•12 years ago
|
||
I'm not going to ever follow up on this...
Assignee: gavin.sharp → nobody
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•6 years ago
|
Component: XP Toolkit/Widgets: Menus → XUL
You need to log in
before you can comment on or make changes to this bug.
Description
•