Ian Neal Assignee
	Description • 14 years ago

In toolkit bug 506175 a new method for SimpleTest, waitForFocus, was introduced to help fix an intermittent orange they were having on linux tinderboxes for download manager tests.
We should port this to SM.
With patch applied no fails:
228 INFO Passed: 128
229 INFO Failed: 0
230 INFO Todo:   0

	neil@parkwaycc.co.uk
	Comment 1 • 14 years ago

Comment on attachment 470894 [details] [diff] [review]
Use waitForFocus on relevant download manager tests patch [Checked in: Comment 2]

It's a shame that there's no easy way to avoid reindenting much of the code (I assume Firefox did too); a -w diff would have been helpful.

>+  function continueTest(win) {
...
>   };
Nit: [object] variables need trailing semicolons; functions don't.

	Ian Neal Assignee
	Comment 2 • 14 years ago

Comment on attachment 470894 [details] [diff] [review]
Use waitForFocus on relevant download manager tests patch [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/0fcd53f9120a
With extra semicolons removed and as much re-indenting avoided as possible.

	Serge Gautherie (:sgautherie)
	Comment 3 • 14 years ago

On *-1.9.1, some other test was just fixed by porting the trunk patch with s/SimpleTest.waitForFocus()/addLoadEvent()/.
(To hopefully fix bug 515407 and bug 589616.)

	Robert Kaiser
	Comment 4 • 14 years ago

The seamonkey2.1 flag is not for 2.0!