Closed
Bug 592438
Opened 14 years ago
Closed 14 years ago
Port bug 506175 to SM and fix an intermittent orange on linux for download manager tests
Categories
(SeaMonkey :: Testing Infrastructure, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b1
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
In toolkit bug 506175 a new method for SimpleTest, waitForFocus, was introduced to help fix an intermittent orange they were having on linux tinderboxes for download manager tests.
We should port this to SM.
With patch applied no fails:
228 INFO Passed: 128
229 INFO Failed: 0
230 INFO Todo: 0
Attachment #470894 -
Flags: review?(neil)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 470894 [details] [diff] [review]
Use waitForFocus on relevant download manager tests patch [Checked in: Comment 2]
It's a shame that there's no easy way to avoid reindenting much of the code (I assume Firefox did too); a -w diff would have been helpful.
>+ function continueTest(win) {
...
> };
Nit: [object] variables need trailing semicolons; functions don't.
Attachment #470894 -
Flags: review?(neil) → review+
Blocks: SmTestFail
Comment on attachment 470894 [details] [diff] [review]
Use waitForFocus on relevant download manager tests patch [Checked in: Comment 2]
http://hg.mozilla.org/comm-central/rev/0fcd53f9120a
With extra semicolons removed and as much re-indenting avoided as possible.
Attachment #470894 -
Attachment description: Use waitForFocus on relevant download manager tests patch → Use waitForFocus on relevant download manager tests patch [Checked in: Comment 2]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 3•14 years ago
|
||
On *-1.9.1, some other test was just fixed by porting the trunk patch with s/SimpleTest.waitForFocus()/addLoadEvent()/.
(To hopefully fix bug 515407 and bug 589616.)
status-seamonkey2.1:
--- → ?
You need to log in
before you can comment on or make changes to this bug.
Description
•