Closed
Bug 593003
Opened 14 years ago
Closed 14 years ago
WebConsole: iFrames can get associated to wrong HUD
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(blocking2.0 final+)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: julian.viereck, Assigned: msucan)
References
Details
(Whiteboard: [kd4b7])
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
dangoor
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
It seems like iFrames get associated to the WebConsole that is opened in the current selected tab and not the WebConsole of the parentWindow the iFrames is added to.
Testcase:
Open the WebConsole on http://www.heise.de/ and on another page. Reload heise.de and switch over to the other tab with opened WebConsole. You will see network logging of iFrames of the heise.de page in the false/other WebConsole.
Patch:
The patch enclosed checks if the initialized window is an iFrames. If that's try the top most parent window is queried and the hudId is looked up by looking up the hudid associated with the parentWindow.
Updated•14 years ago
|
Assignee: nobody → pwalton
Whiteboard: [kd4b6]
Updated•14 years ago
|
Attachment #471460 -
Flags: feedback?(ddahl)
Updated•14 years ago
|
Severity: normal → blocker
Updated•14 years ago
|
blocking2.0: --- → ?
Updated•14 years ago
|
Assignee: pwalton → mihai.sucan
Comment 1•14 years ago
|
||
Reprioritizing bugs. You can filter the mail on the word TEABAGS.
Severity: blocker → normal
Whiteboard: [kd4b6] → [kd4b7]
Assignee | ||
Comment 2•14 years ago
|
||
Proposed fix. The previous patch was correct in its intent on how to fix the issue, but there were some bugs which caused the entire WebConsole to fail during windowInitialize() - I think Julian did not have sufficient time to test the patch.
In this patch I've corrected the fix for the windowInitializer method, and I have also included an automatic test for the problem.
Attachment #471460 -
Attachment is obsolete: true
Attachment #472615 -
Flags: feedback?(ddahl)
Attachment #471460 -
Flags: feedback?(ddahl)
Assignee | ||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Updated•14 years ago
|
Attachment #472615 -
Flags: feedback?(ddahl) → feedback+
Assignee | ||
Comment 3•14 years ago
|
||
Comment on attachment 472615 [details] [diff] [review]
proposed patch
Thank you David for the feedback+!
Asking for review from Shawn.
Attachment #472615 -
Flags: review?(sdwilsh)
Comment 4•14 years ago
|
||
Comment on attachment 472615 [details] [diff] [review]
proposed patch
nit: use the public domain license header in the tests please per http://www.mozilla.org/MPL/license-policy.html
r=sdwilsh
Attachment #472615 -
Flags: review?(sdwilsh) → review+
Assignee | ||
Comment 5•14 years ago
|
||
Updated patch per reviewer comment. Thanks Shawn!
Attachment #472615 -
Attachment is obsolete: true
Comment 6•14 years ago
|
||
Comment on attachment 473143 [details] [diff] [review]
[checked-in] updated patch
carried forward r+. approval requested to land this improvement to the console's handling of iframes.
Attachment #473143 -
Flags: review+
Attachment #473143 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #473143 -
Flags: approval2.0? → approval2.0+
Updated•14 years ago
|
blocking2.0: ? → final+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Updated•14 years ago
|
Blocks: devtools4b7
Comment 7•14 years ago
|
||
Comment on attachment 473143 [details] [diff] [review]
[checked-in] updated patch
http://hg.mozilla.org/mozilla-central/rev/a7d83f9da547
Attachment #473143 -
Attachment description: updated patch → [checked-in] updated patch
Updated•14 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 8•14 years ago
|
||
Marking the bug as fixed.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•