Closed Bug 593116 Opened 14 years ago Closed 14 years ago

Use -fomit-frame-pointer when compiling jsinterp.c

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

Details

Attachments

(1 file)

Patch v1
(deleted), patch
ted
: review+
sayrer
: approval2.0+
Details | Diff | Splinter Review
js/src/Makefile.in explicitly sets the flags for jsinterp.c to -O3 -fstrict-aliasing when using GCC. But the MODULE_OPTIMIZE_FLAGS are set to -O3 -fstrict-aliasing -fomit-frame-pointer $(MOZ_OPTIMIZE_SIZE_TWEAK), which seems much better.
I may fix this in Bug 592923, unless there are objections.
Fix up in bug 592923.
Attached patch Patch v1 (deleted) — — Splinter Review
Here's the stand-alone patch for this that I probably should have written in the first place.
Attachment #474140 - Flags: review?(ted.mielczarek)
dvander measured and said this *might* be a 1-2% win on V8.
(In reply to comment #5) > What does "might" mean? Probably that there's too much variance to really tell. I'm pushing to try now.
(In reply to comment #5) > What does "might" mean? Statistical significance.
I'm happy to land this if we get approval.
Comment on attachment 474140 [details] [diff] [review] Patch v1 I think I ignored this because you had it patched elsewhere, but this is good.
Attachment #474140 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → justin.lebar+bug
Attachment #474140 - Flags: approval2.0?
This looks good on try.
Attachment #474140 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/19b83a1f22db
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: