Closed
Bug 593377
Opened 14 years ago
Closed 14 years ago
bug 535922 killed all tests in dom/tests/browser
Categories
(Core :: DOM: Core & HTML, defect, P1)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Bug 535922's patch killed all tests in dom/tests/browser. I'll post the patch, but unfortunately, we miss-catch a regression by this regression.
|
Assignee | |
Comment 1•14 years ago
|
||
I'll request a review after I confirm that all tests pass on tryserver.
|
||
Comment 2•14 years ago
|
||
Um... We had the same issue with the docshell tests from the same patch too. Was the patch not audited for similar problems after that? Are there any other parts of our test suite it conveniently disabled?
blocking2.0: --- → ?
|
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to comment #2)
> Um... We had the same issue with the docshell tests from the same patch too.
> Was the patch not audited for similar problems after that? Are there any other
> parts of our test suite it conveniently disabled?
I'm not sure, I found this bug when I tried to add a new test for bug 591890.
Doesn't the docshell work fine too? Looks like docshell folder is in _tests/testing/mochitest/browser.
|
||
Updated•14 years ago
|
blocking2.0: ? → final+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 471858 [details] [diff] [review]
Patch v1.0
passed on Mac and Linux.
Boris, would you review this?
Attachment #471858 -
Flags: review?(bzbarsky)
|
|
||
Comment 5•14 years ago
|
||
Comment on attachment 471858 [details] [diff] [review]
Patch v1.0
r=me
Attachment #471858 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
Thank you, I'll land it tomorrow morning.
|
|
Assignee | |
Comment 7•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•