Closed
Bug 593416
Opened 14 years ago
Closed 14 years ago
Bug 544816 landing breaks testGoButtonOnTypeOnly
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pxbugz, Assigned: pxbugz)
References
()
Details
(Keywords: regression, Whiteboard: [mozmill-test-failure])
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100903 Firefox/4.0b6pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100903 Firefox/4.0b6pre
Go button is now part of urlbar
Reproducible: Always
Assignee | ||
Updated•14 years ago
|
Whiteboard: [mozmill-test-failure]
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #471914 -
Flags: review?(hskupin)
Updated•14 years ago
|
Status: UNCONFIRMED → ASSIGNED
Component: Location Bar → Mozmill Tests
Ever confirmed: true
Product: Firefox → Testing
QA Contact: location.bar → mozmilltests
Version: unspecified → Trunk
Comment 2•14 years ago
|
||
Thanks Steve! For the future please also add the information below in the initial comment:
MODULE: firefox/testAwesomeBar/testGoButton.js
TEST: testGoButtonOnTypeOnly
FAIL: controller.assertJS: Failed for 'subject.visible == subject.expectedVisibility'
BRANCH: trunk
Updated•14 years ago
|
Blocks: 544816
Keywords: regression
Comment 3•14 years ago
|
||
(In reply to comment #1)
> Created attachment 471914 [details] [diff] [review]
> Change to call url-go-button
indentation nit:
case "goButton":
- elem = new elementslib.ID(this._controller.window.document, "go-button");
+ elem = new elementslib.ID(controller.window.document, "urlbar-go-button")
Comment 4•14 years ago
|
||
Comment on attachment 471914 [details] [diff] [review]
Change to call url-go-button
>diff --git a/shared-modules/testToolbarAPI.js b/shared-modules/testToolbarAPI.js
>- elem = new elementslib.ID(this._controller.window.document, "go-button");
>+ elem = new elementslib.ID(controller.window.document, "urlbar-go-button")
controller doesn't exist in the API. It's probably a c&p failure from your testing. Check the line above how it has to look like. Also please remove the tab characters at the beginning of the line and replace it with spaces. And a final semicolon would be nice too. Otherwise good find!
Attachment #471914 -
Flags: review?(hskupin) → review-
Updated•14 years ago
|
Assignee: nobody → pxbugz
Assignee | ||
Comment 5•14 years ago
|
||
Attachment #471914 -
Attachment is obsolete: true
Assignee | ||
Comment 6•14 years ago
|
||
Attachment #471955 -
Attachment is obsolete: true
Comment 7•14 years ago
|
||
Comment on attachment 471956 [details] [diff] [review]
Updated with the right patch
Will check tomorrow. Thanks for the updated patch.
Attachment #471956 -
Flags: review?(hskupin)
Updated•14 years ago
|
Attachment #471956 -
Flags: review?(hskupin) → review+
Comment 8•14 years ago
|
||
Landed on default as:
http://hg.mozilla.org/qa/mozmill-tests/rev/47ba3ed824d8
Thanks again! Good to see that you were able to catch up so fast.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Summary: [mozmill] Bug 544816 landing breaks testGoButton.js → Bug 544816 landing breaks testGoButtonOnTypeOnly
Comment 9•14 years ago
|
||
Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Product: Testing → Mozilla QA
Version: Trunk → unspecified
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•