Closed Bug 593440 Opened 14 years ago Closed 14 years ago

Remove remaining child content widgets

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jimm, Assigned: jimm)

References

Details

Attachments

(1 file, 2 obsolete files)

patch v.2
(deleted), patch
roc
: review+
joe
: approval2.0+
Details | Diff | Splinter Review
Attached patch patch (obsolete) (deleted) — — Splinter Review
We did this for main windows, but we never enabled it for dialogs and popups. For simplicity sake, we should go ahead and remove these as well so the widget hierarchy is the same for all top level windows.
Depends on: 513162
Attached patch patch (obsolete) (deleted) — — Splinter Review
Assignee: nobody → jmathies
Attachment #471937 - Attachment is obsolete: true
Attachment #471940 - Flags: review?(bzbarsky)
Hmm, now that 130078 has landed, I might be able to just take those all out and it would work the same. Will test.
Comment on attachment 471940 [details] [diff] [review] patch Better for roc to look, I think.
Attachment #471940 - Flags: review?(bzbarsky) → review?(roc)
(In reply to comment #2) > Hmm, now that 130078 has landed, I might be able to just take those all out and > it would work the same. Will test. Looks like we can still have eWindowType_child and eWindowType_invisible pass through here. (I can probably add invisible as well.) I think though I still need to filter based on the type.
Comment on attachment 471940 [details] [diff] [review] patch we hit eWindowType_popup here, really?
(In reply to comment #5) > Comment on attachment 471940 [details] [diff] [review] > patch > > we hit eWindowType_popup here, really? I can confirm, but aren't popups chrome documents contained in top level widgets? (tooltips for example?)
Comment on attachment 471940 [details] [diff] [review] patch I stand corrected. Popup creation doesn't pass through here and they don't share the child window hierarchy that toplevel and dialogs had. Updated patch coming up.
Attachment #471940 - Flags: review?(roc) → review-
Attached patch patch v.2 (deleted) — — Splinter Review
Attachment #471940 - Attachment is obsolete: true
Attachment #472735 - Flags: review?(roc)
Attachment #472735 - Flags: approval2.0?
Attachment #472735 - Flags: approval2.0? → approval2.0+
Summary: Remove child content windows from dialogs and popups → Remove remaining child content widgets
http://hg.mozilla.org/mozilla-central/rev/c45881749e3f
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: