We have decided that we're not going to ship the Inspector tool in Firefox 4. However, we've made good progress on the tool and want to keep the work so far. The Inspector hooks into Firefox just through the menu item, so we can hide the menu item behind a preference.

This needs to be done in beta 6.

Reprioritizing bugs. You can filter the mail on the word TEABAGS.

Yep - if it's not shipping in FF4, it should not be in our feature-frozen beta. beta6+

Comment on attachment 472411 [details] [diff] [review] Inspector disable menu and key command Same issue as the other patch - using a <command> element for this would be cleaner, and need to either add a try/catch or a default value for the pref, to avoid the getBoolPref call throwing.

Using Command. Changed pref to just devtools.inspector.enabled as the web console is not using the browser prefix. Added the pref to firefox defaults.

added appmenu menu item to the party of disablement.

Comment on attachment 473672 [details] [diff] [review] [checked-in] Inspector disable menu and key command 3 >diff --git a/browser/app/profile/firefox.js b/browser/app/profile/firefox.js >+// disable the Inspector >+pref("devtools.inspector.enabled", false); Probably shouldn't put this between two "download" prefs (maybe put it at the end?) >diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js >+ // Enable Inspector? >+ let enabled = gPrefService.getBoolPref(InspectorUI.prefEnabledName); >+ if (enabled) { >+ document.getElementById("menu_pageinspect").setAttribute("hidden", false); >+ document.getElementById("Tools:Inspect").removeAttribute("disabled"); >+ let appMenuInspect = document.getElementById("appmenu_pageInspect"); >+ if (appMenuInspect) >+ appMenuInspect.setAttribute("hidden", false); >+ } Can use .hidden and .disabled rather than setAttribute/removeAttribute.

Comment on attachment 473672 [details] [diff] [review] [checked-in] Inspector disable menu and key command 3 http://hg.mozilla.org/mozilla-central/rev/1fc25e5fe837

Verified fixed using hourly build Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100910 Firefox/4.0b6pre from cset cca361001fda Inspect is hidden in tools menu and the firefox button. Flipping the pref to true and then restarting Firefox shows the menu entry in both locations.