Closed
Bug 594037
Opened 14 years ago
Closed 13 years ago
Fine tuning of Firefox Button
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: Terepin, Unassigned)
References
Details
Attachments
(1 file, 4 obsolete files)
(deleted),
image/png
|
Details |
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100907 Firefox/4.0b6pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100907 Firefox/4.0b6pre
1. Bug: In pressed state it turns into perfect rectangle.
2. Correction: Requires margin-left: 1px.
Reproducible: Always
Reporter | ||
Comment 1•14 years ago
|
||
(In reply to comment #0)
> 2. Correction: Requires margin-left: 1px.
Damn:
2. Correction: Requires margin-left: 1px in maximized window.
Comment 2•14 years ago
|
||
(In reply to comment #0)
> 1. Bug: In pressed state it turns into perfect rectangle.
That is intended.
Reporter | ||
Comment 3•14 years ago
|
||
Why?
Comment 4•14 years ago
|
||
Discussed in bug 574681 comment 26.
Reporter | ||
Comment 5•14 years ago
|
||
Oh. Ignore point number one then. Just need that margin correction.
3. Bug: Oh and yes, the hover effect is indeed delayed, in both ways.
Comment 6•14 years ago
|
||
When aero is enabled, the button looks strange when the menu is shown, because of the 2 pixel border creating a gap. Could the bottom border be removed when the menu is shown?
Comment 7•14 years ago
|
||
It also appears to be taller than the other window controls.
Reporter | ||
Comment 8•14 years ago
|
||
In my case the button is taller because of regression in bug 578620.
Comment 9•14 years ago
|
||
The position of the Firefox button in a restored window is not quite correct. It needs to be moved to the left two pixels.
Updated•14 years ago
|
Assignee: nobody → dao
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 10•14 years ago
|
||
(In reply to comment #8)
> In my case the button is taller because of regression in bug 578620.
Ah, that is my problem as well.
Status: NEW → UNCONFIRMED
Ever confirmed: false
Reporter | ||
Comment 12•14 years ago
|
||
Shouldn't be hard to fix this. Basically it needs only few margin corrections.
Comment 13•14 years ago
|
||
What's the reason of transparent FXB when window is unfocused?
Reporter | ||
Comment 14•14 years ago
|
||
The caption buttons is the reason.
Comment 15•14 years ago
|
||
So using the same logic as comment 14, wouldn't it make sense to use the same kind of shadow the caption buttons have then? The light upper part and the darker bottom part I mean, which make them look rounded (or triangle-shaped, because the shadow edge is very sharp). The Firefox button doesn't have such three dimensionality, just a soft gradient.
Comment 16•14 years ago
|
||
pino, the designer already considered that and opted to not be so glossy. It's an intentional distinction/deviation.
So, it appears that the pressed state shape and the position of the button are wrong and there is no one signed up to fix it.
Shorlander, do you consider this important enough to block the release?
Reporter | ||
Comment 17•14 years ago
|
||
(In reply to comment #16)
> So, it appears that the pressed state shape
Acording to Stephen, it isn't.
Comment 18•14 years ago
|
||
(In reply to comment #16)
> Shorlander, do you consider this important enough to block the release?
I don't think this should block release. However it should be a fairly simple patch so I plan to look at it when I get a moment if someone else doesn't pick it up first.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 19•14 years ago
|
||
(In reply to comment #12)
> Shouldn't be hard to fix this. Basically it needs only few margin corrections.
This is not true, I've tried making the margin adjustments and it is unable to draw in the left border area.
Comment 20•14 years ago
|
||
(In reply to Bug 574681 comment #82)
> There seems to be a slight delay when going from an inactive to an active
> button.
I'm curious, if this can be fixed... Firefox feels rather slow, e.g. when Alt-Tab'ing to it, and something flashes in your peripheral vision.
Comment 21•14 years ago
|
||
Curious if the height mismatch was desired, or should I file a bug?
Comment 22•14 years ago
|
||
(In reply to comment #21)
> Created attachment 473105 [details]
> height comparison
>
> Curious if the height mismatch was desired, or should I file a bug?
It is apparently caused by bug 578620.
Reporter | ||
Comment 23•14 years ago
|
||
FXB remains in inactive state.
Comment 24•14 years ago
|
||
When the Firefox window does not have focus, the border around the Firefox button is darker than the border around the window control buttons. It currently matches the window's outside black border I think, but the window controls have a slightly lighter border. Also, when the window does not have focus, the button contents should have a higher contrast stroke/outline to help visibility on lighter backgrounds. Does fine on darker backgrounds but needs help on light or white.
Comment 25•14 years ago
|
||
Also just noticed that if the Firefox menu is open when the window loses focus, the button stays orange instead of going transparent. steps: 1. click firefox button to open menu. 2. click taskbar or some other location to unfocus Firefox window. 3. see orange button. expected: button goes transparent like it does if the menu wasn't open when you de-focused the window.
Comment 26•14 years ago
|
||
Just noticed a small issue with the activation of the button's unfocused window appearance. The appearance of the button doesn't go into its unfocused state if you select another window whilst having the menu open.
Also the button isn't activated when the mouse is at the top-left most pixel of a maximized window, nor is it activated at the left-most edge. This would be a major Fitts' Law benefit.
Comment 27•14 years ago
|
||
The border radius of the button should be increased slightly to matche the radius of the caption buttons.
Comment 28•14 years ago
|
||
What about a glow effect on hover (of course Win Vista and 7 only)?
Comment 29•14 years ago
|
||
(In reply to comment #28)
> What about a glow effect on hover (of course Win Vista and 7 only)?
I did some experimenting with implementing a glow effect with box-shadow, but it only renders to the right and bottom of the button.
Comment 30•14 years ago
|
||
(In reply to comment #27)
> The border radius of the button should be increased slightly to matche the
> radius of the caption buttons.
Yes, it should be increased from 4px to 5px.
Comment 32•14 years ago
|
||
Comment on attachment 472655 [details]
screenshot comparing current Firefox button placement with design doc
obsoleting outdated screenshots
Attachment #472655 -
Attachment is obsolete: true
Updated•14 years ago
|
Attachment #473105 -
Attachment is obsolete: true
Updated•14 years ago
|
Attachment #473491 -
Attachment is obsolete: true
Updated•14 years ago
|
Attachment #474288 -
Attachment is obsolete: true
Comment 33•14 years ago
|
||
Comment 34•14 years ago
|
||
(In reply to comment #33)
> Created attachment 503805 [details]
> Fx button loses rounded corners when pressed
I've just read the comments again, and found this is intended... Why? It looks very odd. Please obsolete the attachment if it's really intended. Sorry.
Comment 35•14 years ago
|
||
I have no idea what the actual goal of this bug is due to the chain of comments.
Stephen/Dao: if you think this should block, please renominate.
blocking2.0: ? → ---
Reporter | ||
Comment 36•14 years ago
|
||
I can summarize what is still valid into one comment if you want. :)
Comment 37•14 years ago
|
||
(In reply to comment #35)
> I have no idea what the actual goal of this bug is due to the chain of
> comments.
>
> Stephen/Dao: if you think this should block, please renominate.
I don't see anything listed here that blocks.
Reporter | ||
Comment 38•13 years ago
|
||
This bug lost its purpose.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•