Closed Bug 594429 Opened 14 years ago Closed 14 years ago

Update the live filter search button in Panorama UI

Categories

(Firefox Graveyard :: Panorama, defect, P2)

Product:
Firefox Graveyard
Component:
Panorama
Type:
defect

Tracking

(blocking2.0 final+)

Status:
VERIFIED FIXED
Milestone:
Firefox 4.0b8
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: raymondlee, Assigned: raymondlee)

References

Details

(Whiteboard: [good first bug])

Attachments

(2 files, 3 obsolete files)

Screenshot of search button
(deleted), image/png
Details
Patch for check-in
(deleted), patch
Details | Diff | Splinter Review
No description provided.
Depends on: 592045
Priority: -- → P2
Whiteboard: [good first bug]
Do we know what the problem might be? Raymond, please assign to Aza for design once you've provided more info.
Assignee: nobody → raymond
Attached image Screenshot of search button (deleted) —
The magnify glass isn't very visible.
Assignee: raymond → aza
OS: Windows Vista → Windows 7
Assignee: aza → smartell
Blocks: 598154
OS: Windows 7 → Windows XP
Target Milestone: --- → Firefox 4.0
Assigning to Sean Martell, as he is handling the creation of those glyphs.
Depends on: 597269
In the latest mockups, I've replaced the search glyph with one that matches the overall glyph style within FF4: http://mozilla.seanmartell.com/tabcandy/index.html http://mozilla.seanmartell.com/tabcandy/index-win2.html
Thanks Sean, those look snazzy. Raymond, can you implement?
Assignee: smartell → raymond
OS: Windows XP → All
Summary: Ensure live filter search in Panorama UI looks good on Windows → Update the live filter search button in Panorama UI
Attached patch v1 (obsolete) (deleted) — — Splinter Review
Attachment #489445 - Flags: feedback?(ian)
Status: NEW → ASSIGNED
Comment on attachment 489445 [details] [diff] [review] v1 Looks fine
Attachment #489445 - Flags: feedback?(ian) → feedback+
Attachment #489445 - Flags: review?(dao)
Comment on attachment 489445 [details] [diff] [review] v1 Use -moz-margin-end instead of margin-right.
Attachment #489445 - Flags: review?(dao) → review+
Attached patch v1 (obsolete) (deleted) — — Splinter Review
Replaced -moz-margin-end with margin-right. a=dao
Attachment #489445 - Attachment is obsolete: true
Attachment #489819 - Flags: approval2.0?
(In reply to comment #9) > Created attachment 489819 [details] [diff] [review] > v1 > > Replaced -moz-margin-end with margin-right. > > a=dao That should be r=dao. Does it need a try run?
(In reply to comment #10) > (In reply to comment #9) > > Created attachment 489819 [details] [diff] [review] [details] > > v1 > > > > Replaced -moz-margin-end with margin-right. > > > > a=dao > > That should be r=dao. > > Does it need a try run? I don't think we need a try run because the patch just updates some CSS.
(In reply to comment #11) > > I don't think we need a try run because the patch just updates some CSS. Fair enough.
Marking blocking, approval not needed.
blocking2.0: --- → final+
Attached patch Patch for check-in (obsolete) (deleted) — — Splinter Review
Attachment #489819 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/88cca1740749
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
This bug was part of a mass backout to fix the permanent leak on OS X 64 that this push caused. http://hg.mozilla.org/mozilla-central/rev/b014423f755b
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Patch for check-in (deleted) — — Splinter Review
Attachment #492670 - Attachment is obsolete: true
Sent it to try and passed with intermittent orange.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/98184990f3ba
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: Firefox 4.0 → Firefox 4.0b8
Verified in recent nightly minefield build
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: