Closed
Bug 594613
Opened 14 years ago
Closed 14 years ago
Fastload not invalidated after building with pymake
Categories
(Toolkit Graveyard :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: zpao, Assigned: benedict)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
`python -O ../build/pymake/make.py -C browser/components`
is not causing my fastload to be invalidated. This is a debug build.
.purgecaches is not being created.
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → bhsieh
|
|
Assignee | |
Comment 1•14 years ago
|
||
I've been told that make.py should still pass the
|if test -d ../dist/bin ; then touch ../dist/bin/.purgecaches ; fi|
command to the shell. I wonder if MozillaBuild maybe doesn't support one of the commands in there?
|
||
Comment 2•14 years ago
|
||
Seems pretty unlikely.
|
|
Assignee | |
Comment 3•14 years ago
|
||
Noticed that on Windows, this line doesn't show up at all when I do make:
> if test -d $(DIST)/bin ; then touch $(DIST)/bin/.purgecaches ; fi
and it does on other platforms.
The line comes from http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#2360 or the rules.mk file in /js.
|
|
Assignee | |
Comment 4•14 years ago
|
||
http://mozilla.pastebin.com/u8Wcbh1S is the tail end of the output from make -d.
Looks like that line isn't getting executed at all. From here, I'm not sure what to do other than muck around with Makefiles to see if I can find something Windows make is happy with.
|
|
Assignee | |
Comment 5•14 years ago
|
||
So, looks like using the libs target instead of the default target works. I don't remember if only invalidating on make libs misses any corner cases, but I think it should be ok.
|
|
Assignee | |
Comment 6•14 years ago
|
||
Attachment #474276 -
Flags: review?(benjamin)
Attachment #474276 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #474276 -
Flags: review?(benjamin)
Attachment #474276 -
Flags: review-
Attachment #474276 -
Flags: approval2.0?
|
|
Assignee | |
Comment 7•14 years ago
|
||
Attachment #474276 -
Attachment is obsolete: true
Attachment #475345 -
Flags: approval2.0?
|
|
||
Updated•14 years ago
|
Attachment #475345 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 8•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Updated•14 years ago
|
Target Milestone: --- → mozilla2.0b7
|
||
Updated•6 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•