This bug covers adding the sync command and submenu to the Firefox menu. Details are in the attached mockup, note that clicking the main item should not dismiss the menu so that the user can see visual feedback of the action taking place. Also note that this command appears at the bottom to have a close mapping to exit, and on the right side so it is grouped with the user data (bookmarks, history, preferences) that are being synchronized.

Note that we're looking to kill connect/disconnect and just internally "log in" when a user is trying to or scheduled to sync, so other than the "last sync" time, I don't think we need/want a submenu here. I'm a little worried about the Sync Complete concept, without the other items, as I always have been, since I think it can present a confusing picture... do we really need that?

I would really like to get to the point of having a single menu item (Set Up Sync... / Sync Now) and that's it, mirroring the button behaviour. If we want to display time since completion, I really think that can go in the prefwindow, and we don't need to get into the "local state == the world" trap.

Just for reference, we just discussed this on IRC: <mconnor> basically, we already want to kill connect/disconnect <mconnor> so the only reason for a submenu would be the last sync time <mconnor> but I think that can move to the prefpane <mconnor> and the tooltip for the button, for people who have the button <mconnor> so I kinda want to have one of two menuitems there: Sync Now and Set Up Sync... <limi> mconnor: sounds good to me, faaborg agrees too. It would be "Set up Sync" if you haven't, and "Sync Now" if you have, right? <limi> ie. they are mutually exclusive <mconnor> yes <limi> go go go :)

Can someone explain to me how can a user disconnect his sync without connect/disconnect ?

If you want to stop syncing a computer, you can remove your account from the computer. Note that "disconnect" didn't prevent anything from being synced, we'd just track changes and sync on next connect.

Why don't we include the option to remove Sync account from this computer in the Sync Sub-Menu ? Since we already have the Set up Sync, it is reasonable and logical to have a remove option in the UI itself.

That's the type of command the user might do once or twice, so it belongs in the options window instaed of the application menu.

Comment on attachment 474194 [details] [diff] [review] v1 >diff --git a/browser/base/content/browser-sets.inc b/browser/base/content/browser-sets.inc >+ <broadcaster id="sync-lastsyncsep-state" hidden="true"/> >+ <broadcaster id="sync-lastsync-state" disabled="true" hidden="true"/> Omit these (as you mentioned) >diff --git a/browser/base/content/browser-syncui.js b/browser/base/content/browser-syncui.js > doUpdateMenu: function SUI_doUpdateMenu(event) { You seem to be removing the only caller of this method - remove it? >diff --git a/browser/base/content/browser.xul b/browser/base/content/browser.xul >+#ifdef MOZ_SERVICES_SYNC >+ <spacer flex="1"/> >+ <!-- only one of sync-setup or sync-syncnow will be showing at once --> >+ <menuitem id="sync-setup-appmenu" Indentation looks messed up here. >diff --git a/browser/locales/en-US/chrome/browser/browser.dtd b/browser/locales/en-US/chrome/browser/browser.dtd >-<!ENTITY syncLogInItem.label "Connect"> I guess this is on top of the patch for bug 594488 (the other use of this string is being removed there)

verified with recent versions of minefield