Closed Bug 594874 Opened 14 years ago Closed 14 years ago

GfxInfo blocklist needs to be used by D3D, WebGL, OpenGL

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: vlad, Assigned: bjacob)

References

Details

Attachments

(3 files, 1 obsolete file)

Part 1: OpenGL layers
(deleted), patch
vlad
: review+
Details | Diff | Splinter Review
Part 2: Direct3D 9
(deleted), patch
vlad
: review+
Details | Diff | Splinter Review
Part 3: WebGL
(deleted), patch
vlad
: review+
Details | Diff | Splinter Review
The GfxInfo driver blocklist needs to be checked before we create a D3D/OpenGL layer manager or a WebGL context. Right now it's only checked in one spot for creating a D2D context.
blocking2.0: --- → betaN+
Assignee: nobody → bjacob
Attached patch Part 1: OpenGL layers (deleted) — — Splinter Review
Attachment #476025 - Flags: review?(vladimir)
Comment on attachment 476025 [details] [diff] [review] Part 1: OpenGL layers seems like we should do something with the not-recommended return here as well, but fine for a first start.
Attachment #476025 - Flags: review?(vladimir) → review+
Attached patch Part 2: Direct3D 9 (deleted) — — Splinter Review
Attachment #476055 - Flags: review?(vladimir)
Attached patch Part 3: WebGL (obsolete) (deleted) — — Splinter Review
Attachment #476056 - Flags: review?(vladimir)
argh! no! sorry! typos! gimme a minute
Attachment #476055 - Flags: review?(vladimir) → review+
Comment on attachment 476056 [details] [diff] [review] Part 3: WebGL Wrong comment and feature selector for WebGL :-)
Attached patch Part 3: WebGL (deleted) — — Splinter Review
Attachment #476066 - Attachment description: P → Part 3: WebGL
Attachment #476066 - Attachment is patch: true
Attachment #476066 - Attachment mime type: application/octet-stream → text/plain
Attachment #476066 - Flags: review?(vladimir)
Attachment #476056 - Attachment is obsolete: true
Attachment #476056 - Flags: review?(vladimir)
Yes. Can you review the new patch? I am unsure as to if it safe to say that EGL == ANGLE. Otherwise I don't know how to honor the ANGLE blocklist.
Attachment #476066 - Flags: review?(vladimir) → review+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
For some reason this breaks my builds because LayerManagerD3D9.cpp uses do_GetService without explicitly including nsServiceManagerUtils.h (I don't know what normally includes it, might be the D2D surface perhaps.)
Depends on: 620669
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: