Closed
Bug 595139
Opened 14 years ago
Closed 14 years ago
Use global VACUUM in Places
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla2.0b9
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: mak, Assigned: mak)
References
Details
(Whiteboard: [fixed-in-places])
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Once we have global VACUUM component, we should replace our internal implementation.
|
Assignee | |
Comment 1•14 years ago
|
||
on top of the r+sr patch for global vacuum.
Attachment #474017 -
Attachment is obsolete: true
Attachment #482532 -
Flags: review?(sdwilsh)
|
||
Comment 2•14 years ago
|
||
This should block the final release. It does take care of a few edge cases that the current places code does not handle.
blocking2.0: --- → final+
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 482532 [details] [diff] [review]
patch v1.0
> // nsIDownloadHistory **********************************************************
While here, want to fix this one's style?
r=sdwilsh for pure awesome and code removal :)
Attachment #482532 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [can land in places]
|
|
Assignee | |
Comment 4•14 years ago
|
||
also removed the vacuum workaround in test_adaptive.js
Attachment #482532 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•14 years ago
|
||
Whiteboard: [can land in places] → [fixed-in-places]
|
|
Assignee | |
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
|
||
Comment 7•14 years ago
|
||
Was this backed out again ? I'm not seeing the changes in MXR at all*, even though I can see them in hg**. Is MXR still up-to-date ?
* http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsNavHistory.cpp
** http://hg.mozilla.org/mozilla-central/log/ed37d1bcaea4/toolkit/components/places/src/nsNavHistory.cpp
|
|
Assignee | |
Comment 8•14 years ago
|
||
mxr did not get the merge yet, from what I can tell. all places files are outdated.
|
|
||
Comment 9•14 years ago
|
||
(In reply to comment #7)
> Was this backed out again ? I'm not seeing the changes in MXR at all*, even
> though I can see them in hg**. Is MXR still up-to-date ?
mxr hasn't been updating. This is being tracked in bug 620256.
You need to log in
before you can comment on or make changes to this bug.
Description
•