Closed
Bug 595697
Opened 14 years ago
Closed 14 years ago
"nsIPluginInstance.h(30) : warning C4099: 'gfxASurface' : type name first seen using 'class' now seen using 'struct'"
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: sgautherie, Assigned: romaxa)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
benjamin
:
review+
jst
:
approval2.0+
|
Details | Diff | Splinter Review |
(I hadn't tried to build locally for a long time...)
{
...\dist\include\nsIPluginInstance.h(30) : warning C4099: 'gfxASurface' : type name first seen using 'class' now seen using 'struct'
...\dist\include\gfxASurface.h(56) : see declaration of 'gfxASurface'
}
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxASurface.h
56 class THEBES_API gfxASurface {
http://mxr.mozilla.org/mozilla-central/source/modules/plugin/base/public/nsIPluginInstance.idl
50 struct gfxASurface;
|
Reporter | |
Updated•14 years ago
|
Severity: blocker → minor
|
Assignee | |
Comment 1•14 years ago
|
||
should we declare gfxASurface as class or something?
Yes. This is one of MSVC's completely useless warnings.
|
|
Assignee | |
Comment 3•14 years ago
|
||
Assignee: nobody → romaxa
Attachment #485123 -
Flags: review?(benjamin)
|
||
Updated•14 years ago
|
Attachment #485123 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Comment on attachment 485123 [details] [diff] [review]
Trivial fix
Can someone push it or just give approval?
Attachment #485123 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #485123 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Keywords: checkin-needed
Target Milestone: --- → mozilla2.0b8
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•