Phil Ringnalda (:philor) Reporter
	Description • 14 years ago

I thought someone filed this back when it first started happening, but I don't see any sign of it.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1284405392.1284406285.16298.gz
Rev3 Fedora 12x64 mozilla-central talos tp4 on 2010/09/13 12:16:32  

FAIL: Failed to send data 5 times... quitting
RETURN:send failed, graph server says:
RETURN:to determine average from 'test_run_values' for  5337303 - local variable 'values' referenced before assignment
RETURN:  File "/data/www/graphs.mozilla.org/server/pyfomatic/collect.py", line 257, in handleRequest
RETURN:    average = valuesReader(databaseCursor, databaseModule, inputStream, metadata)
RETURN:  File "/data/www/graphs.mozilla.org/server/pyfomatic/collect.py", line 215, in valuesReader
RETURN:    raise DatabaseException("to determine average from 'test_run_values' for  %s - %s" % (metadata.test_run_id, str(x)))
RETURN:
RETURN:

	Phil Ringnalda (:philor) Reporter
	Comment 1 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1284490669.1284491896.10170.gz

	Phil Ringnalda (:philor) Reporter
	Comment 2 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1284581416.1284582731.25607.gz

	Phil Ringnalda (:philor) Reporter
	Comment 3 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1284602349.1284603275.6546.gz

	Phil Ringnalda (:philor) Reporter
	Comment 4 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1284621220.1284622269.4200.gz

	Phil Ringnalda (:philor) Reporter
	Comment 5 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1285641229.1285642211.20385.gz

	Phil Ringnalda (:philor) Reporter
	Comment 6 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1286217849.1286218863.16830.gz

	Phil Ringnalda (:philor) Reporter
	Comment 7 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1286497875.1286498868.26369.gz

	Phil Ringnalda (:philor) Reporter
	Comment 8 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1286921197.1286922141.23606.gz

	Phil Ringnalda (:philor) Reporter
	Comment 9 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1286938216.1286939144.4145.gz

	Phil Ringnalda (:philor) Reporter
	Comment 10 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1286988936.1286989879.15648.gz

	Phil Ringnalda (:philor) Reporter
	Comment 11 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1287272323.1287273227.1673.gz

	Phil Ringnalda (:philor) Reporter
	Comment 12 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1287518483.1287519502.795.gz

	Phil Ringnalda (:philor) Reporter
	Comment 13 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1288035947.1288036978.6176.gz

	alice nodelman [:alice] [:anode] Assignee
	Comment 14 • 14 years ago

I'm going to try and diagnose this.

	Phil Ringnalda (:philor) Reporter
	Comment 15 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1288787907.1288788810.28758.gz

	alice nodelman [:alice] [:anode] Assignee
	Comment 16 • 14 years ago

My current theory is that we sometimes fail to collect any xres information (which needs to be diagnosed separately) and then we attempt to send an empty data set to the graph server.  This catches this case.

	Phil Ringnalda (:philor) Reporter
	Comment 17 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1288818950.1288819884.7617.gz

	Phil Ringnalda (:philor) Reporter
	Comment 19 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1288993214.1288994135.4489.gz

	Jeff Hammel
	Comment 20 • 14 years ago

Comment on attachment 487937 [details] [diff] [review]
[checked in]don't send empty data sets to the graph server

looks good :)

	alice nodelman [:alice] [:anode] Assignee
	Comment 21 • 14 years ago

Tested green on tools-r3-fed-002, with minor code change (ensure that variable is defined before use).

	alice nodelman [:alice] [:anode] Assignee
	Comment 22 • 14 years ago

Comment on attachment 487937 [details] [diff] [review]
[checked in]don't send empty data sets to the graph server

Checked in, changeset:   207:5c7b44ac3599

	Phil Ringnalda (:philor) Reporter
	Comment 23 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1289502761.1289503662.29575.gz

	Phil Ringnalda (:philor) Reporter
	Comment 24 • 14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1289569349.1289570223.9813.gz

	alice nodelman [:alice] [:anode] Assignee
	Comment 25 • 14 years ago

The error has stopped occurring since releng landed the update to talos.zip.