Closed
Bug 596063
Opened 14 years ago
Closed 14 years ago
Fix 4 "warning: suggest parentheses around && within ||" warnings in SVGLengthListSMILType
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: dholbert, Assigned: juca)
References
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
(deleted),
patch
|
dholbert
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
Just noticed this go by in my GCC compile-spew (in up-to-date mozilla-central):
>SVGLengthListSMILType.cpp: In member function ‘virtual nsresult mozilla::SVGLengthListSMILType::ComputeDistance(const nsSMILValue&, const nsSMILValue&, double&) const’:
> SVGLengthListSMILType.cpp:183: warning: suggest parentheses around && within ||
> SVGLengthListSMILType.cpp:183: warning: suggest parentheses around && within ||
> SVGLengthListSMILType.cpp: In member function ‘virtual nsresult mozilla::SVGLengthListSMILType::Interpolate(const nsSMILValue&, const nsSMILValue&, double, nsSMILValue&) const’:
> SVGLengthListSMILType.cpp:258: warning: suggest parentheses around && within ||
> SVGLengthListSMILType.cpp:258: warning: suggest parentheses around && within ||
I'm filing this bug on adding the suggested parentheses to silence these warnings.
|
Reporter | |
Updated•14 years ago
|
Whiteboard: [build_warning]
|
||
Comment 1•14 years ago
|
||
That's a weird warning. Doesn't everyone know the precedence of those operators? :)
|
|
Reporter | |
Comment 2•14 years ago
|
||
Probably, but it's nice to have the parens anyway, just to be absolutely clear about what you're testing.
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → juca
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #474923 -
Flags: review?(dholbert)
|
|
Reporter | |
Comment 4•14 years ago
|
||
Comment on attachment 474923 [details] [diff] [review]
add parentheses
Looks good! Thanks for the fix!
Attachment #474923 -
Flags: review?(dholbert)
Attachment #474923 -
Flags: review+
Attachment #474923 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #474923 -
Flags: approval2.0? → approval2.0+
|
|
Reporter | |
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•14 years ago
|
Target Milestone: --- → mozilla2.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•