the final implementation of the addon-bar in Firefox 4 necessitates some changes in the widget module.

* remove the visibility pref * s/hidden/collapsed * don't remove the toolbar ever (hide instead) * update tests this doesn't make any attempt to support <Fx4 at the moment. should be do-able though, so might try to do that in this bug too.

Comment on attachment 475062 [details] [diff] [review] v1 * all widget tests passed in trunk + addon bar patch, beta, and 3.6 * sample addon worked as expected in all of those as well the only change is the removal of the persistence pref. persistence is handled internally in fx4+addonbar, and i think we can live without it on 3.6 (assuming that it even stays supported past the fx4 release).

Comment on attachment 475062 [details] [diff] [review] v1 >- // Bug 574688 replaces the status bar with the add-on bar. This code >- // might be removed when that bug is resolved. It might stay, if we >- // want to support versions of Firefox that don't have the add-on bar. >+ // If being run in a version of Firefox >4, create a separate >+ // addon bar. TODO: just use the status bar? Nit: >4 -> <4? >- // Get the value of the UI visibility pref >- function prefVal() require("preferences-service").get("jetpack.jetpack-core.widget.barIsHidden"); >- >- test.assert(!container(), "UI does not exist when no widgets"); >+ test.assert(container().collapsed, "UI does not visible when no widgets"); Nit: UI does not visible -> UI is not visible Otherwise looks great, r=myk.

thanks. however, due to some check-in last night the widget tests (even without this patch) are failing. so i'm going to hold off until that's resolved.

filed bug 596528 for the test failures.

Updated to support the final changes in the add-on bar as landed. This also changes the default widget size to the small size, 16px, since that's all that is supported in the add-on bar right now. I'll be adding support for big-mode in both ends in subsequent bugs.

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product. To filter bugmail related to this change, filter on the word "looptid".