Closed
Bug 596546
Opened 14 years ago
Closed 14 years ago
nsPlacesDBFlush has a constant timer so it needs to be suspended during idle
Categories
(Toolkit :: Places, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 518804
People
(Reporter: jon.hemming, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
sdwilsh
:
feedback+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.11) Gecko/2009060309 Ubuntu/8.04 (hardy) Firefox/3.0.11
Build Identifier:
When system is idle we shouldn't have any constant timers causing wakeups. Even though nsPlacesDBFlush timer is only waking up between 120s we should have longer sleep time during idle or cancel it.
Reproducible: Always
|
Reporter | |
Comment 1•14 years ago
|
||
Could we use this kind of suspending over here?
Attachment #475469 -
Flags: feedback?(benjamin)
|
|
Reporter | |
Updated•14 years ago
|
|
||
Updated•14 years ago
|
Attachment #475469 -
Flags: feedback?(benjamin) → feedback?(sdwilsh)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 475469 [details] [diff] [review]
Will cancel the timer when display off notification received
This would be the right approach, however all this code is going away in bug 552023 which will land in time for 2.0, so we shouldn't take this.
Attachment #475469 -
Flags: feedback?(sdwilsh) → feedback+
|
|
||
Updated•14 years ago
|
Status: UNCONFIRMED → NEW
Component: General → Places
Ever confirmed: true
Product: Core → Toolkit
QA Contact: general → places
Version: unspecified → Trunk
|
||
Comment 3•14 years ago
|
||
this is fixed in Places branch, indeed this component has been killed.
Whiteboard: [fixed-in-places]
|
|
||
Comment 4•14 years ago
|
||
ehr, actually this is a dupe :(
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
Whiteboard: [fixed-in-places]
You need to log in
before you can comment on or make changes to this bug.
Description
•