Closed
Bug 59707
Opened 24 years ago
Closed 24 years ago
Extract navigator's context menu and allow it to be used elsewhere
Categories
(SeaMonkey :: UI Design, defect, P2)
SeaMonkey
UI Design
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
(Keywords: embed)
Attachments
(3 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
We should pull out the navigator-specific context menu and generalize it so we
can use it in many other places that need it (e.g. the sidebar).
nsContextMenu.js also needs to be cleaned up and made more dynamic, preferably
allowing the caller more control over the state of the menu (e.g. what items
are shown or hidden, enabled or disabled) as well.
Assignee | ||
Comment 1•24 years ago
|
||
I don't think Ben wants this :)
reassigning to module owner, but probably taking this myself in a couple days,
Assignee: ben → don
Component: XP Apps: GUI Features → XP Apps
Comment 2•24 years ago
|
||
reassign to me for now.. if you get to this first blake, reassign to yourself
Assignee: don → alecf
Updated•24 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P2
Target Milestone: --- → mozilla0.6
Comment 3•24 years ago
|
||
I have begun work on this...hope to have something in a few days
Updated•24 years ago
|
Target Milestone: mozilla0.6 → mozilla0.9
Assignee | ||
Comment 5•24 years ago
|
||
We should get a list of tasks together, and making it more dynamic will
probably require a separate bug with different goals.
Keywords: embed
Assignee | ||
Comment 6•24 years ago
|
||
reassigning to me for now. I've got most of this working, and will be working
on it tonight. (that ok, alec?)
Assignee: alecf → blakeross
Status: ASSIGNED → NEW
Assignee | ||
Comment 7•24 years ago
|
||
Comment 8•24 years ago
|
||
this looks good - it's basically what I had begun in my tree, but you completed
it :)
my only comment is to make sure that drag & drop stuff still work, because we
were using that in the onDragStart handler in contentAreaDD.js
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Summary: Break out navigator's context menu, clean it up, & make it more dynamic → Extract navigator's context menu and allow it to be used elsewhere
Assignee | ||
Comment 9•24 years ago
|
||
d&d seems to work fine in all cases. looking for official r= (jag?) and sr=...
Assignee | ||
Comment 10•24 years ago
|
||
Assignee | ||
Comment 11•24 years ago
|
||
the fix for bug 60606 is part of this fix.
Assignee | ||
Comment 12•24 years ago
|
||
Assignee | ||
Comment 13•24 years ago
|
||
This new patch just:
* Includes the part of the fix for bug 60606 that needs to go in with this fix
(I want to test more before I remove navigator.js)
* Removes the little theme cleanup in navigator.js that was part of my former
patch (want to minimize changes to navigator.js as much as possible to ease
merging for jag, who has a patch for it)
* Changes contentAreaContextOverlay.dtd to a more generic title (I
chose "contentAreaCommands.dtd") per a request from jag.
please r/sr, thanks!
Comment 14•24 years ago
|
||
r=jag
Comment 15•24 years ago
|
||
sounds good, I like the "Commands" name instead of "Click" too..
a=alecf
Assignee | ||
Comment 16•24 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 18•24 years ago
|
||
is this really fixed, given that the following comment is in the code:
+| Currently, this code is relatively useless for any other purpose. In the
|
+| longer term, this code will be restructured to make it more reusable.
|
+------------------------------------------------------------------------------
*/
comments?
Assignee | ||
Comment 19•24 years ago
|
||
That was carried over from the old file. Anyways, jag and I will be
refactoring all of this soon.
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•