Closed
Bug 597215
Opened 14 years ago
Closed 14 years ago
Don't do setGrowthIncrement on mobile
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | 2.0b2+ | --- |
People
(Reporter: mwu, Assigned: mwu)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
We don't have enough space to do this.
Attachment #476039 -
Flags: review?(bugmail)
|
||
Comment 1•14 years ago
|
||
(In reply to comment #0)
> We don't have enough space to do this.
I think it would make more sense to adjust the clients instead of changing the storage code to never follow it though, right?
|
||
Comment 2•14 years ago
|
||
Comment on attachment 476039 [details] [diff] [review]
Fix
minusing based on Shawn's comment.
Also, ifdefing on a GFX define in the middle of storage code without a comment does not seem right.
Attachment #476039 -
Flags: review?(bugmail) → review-
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to comment #1)
> (In reply to comment #0)
> > We don't have enough space to do this.
> I think it would make more sense to adjust the clients instead of changing the
> storage code to never follow it though, right?
But it's easier to just adjust it here because we care more about minimizing overall space usage than fragmentation on mobile. I would just adjust all the clients to zero anyway.
|
|
||
Comment 4•14 years ago
|
||
(In reply to comment #3)
> (In reply to comment #1)
> But it's easier to just adjust it here because we care more about minimizing
> overall space usage than fragmentation on mobile. I would just adjust all the
> clients to zero anyway.
Are you sure that's the right thing to do? As I understand it (taras would know better), fragmentation hurts mobile way more than anything else.
|
||
Comment 5•14 years ago
|
||
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #1)
> > But it's easier to just adjust it here because we care more about minimizing
> > overall space usage than fragmentation on mobile. I would just adjust all the
> > clients to zero anyway.
> Are you sure that's the right thing to do? As I understand it (taras would
> know better), fragmentation hurts mobile way more than anything else.
In this case, android is extremely constrained in disk space, so eager preallocation is in conflict. I think it'd be nicer to pref this off, but we cn do that in a followup bug.
|
|
Assignee | |
Comment 6•14 years ago
|
||
On Android, the use of a log-structured file system most likely negates any positive effects of setGrowthIncrement.
Attachment #476039 -
Attachment is obsolete: true
Attachment #477807 -
Flags: review?(sdwilsh)
|
|
||
Comment 7•14 years ago
|
||
Comment on attachment 477807 [details] [diff] [review]
Android only fix
>+// Bug 597215: Disk space is extremely limited on Android
Hate comments in the code that force you to go to the bug to see reasoning. Please elaborate in the comment, but you can still reference the bug number if you want.
r=sdwilsh with that change.
Attachment #477807 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Updated•14 years ago
|
tracking-fennec: --- → ?
|
||
Updated•14 years ago
|
tracking-fennec: ? → 2.0b2+
|
|
Assignee | |
Comment 8•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•