Closed
Bug 597427
Opened 14 years ago
Closed 14 years ago
Sync UI: Use Weave.Utils.generatePassphrase and friends
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: philikon, Assigned: philikon)
References
Details
Attachments
(1 obsolete file)
{generate|hyphenate|normalize}Passphrase() are now available in Weave.Utils (see bug 593820) and can be removed from UI code.
Assignee | ||
Comment 1•14 years ago
|
||
Assignee: nobody → philipp
Attachment #489966 -
Flags: review?(mconnor)
Assignee | ||
Comment 2•14 years ago
|
||
Blocks the simplified crypto work (bug 603489) and blocks us from changing the passphrase munging functions in Sync itself, so it should block b8.
Blocks: 603489
blocking2.0: --- → ?
Comment 3•14 years ago
|
||
Comment on attachment 489966 [details] [diff] [review]
v1
Tested this patch locally with my altered fx-sync repo (including generatePassphrase) and a current mozilla-central, and all seems well.
Attachment #489966 -
Flags: review+
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 489966 [details] [diff] [review]
v1
Actually, I realized the patch only accommodates for generated passphrases (yes, the add-on UI code checks for passphrase length 20 *hangs head in shame*). I'll upload a fixed patch later.
Fortunately we're getting rid of custom passphrases.
Attachment #489966 -
Flags: review?(mconnor)
Updated•14 years ago
|
blocking2.0: ? → final+
Assignee | ||
Comment 5•14 years ago
|
||
I'm going to address this as part of bug 612699.
Assignee | ||
Updated•14 years ago
|
Attachment #489966 -
Attachment is obsolete: true
Assignee | ||
Comment 6•14 years ago
|
||
Bug 612699 landed.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•