Closed
Bug 597499
Opened 14 years ago
Closed 14 years ago
Expand stack icon moves incorrectly and isn't centered
Categories
(Firefox Graveyard :: Panorama, defect, P1)
Firefox Graveyard
Panorama
Tracking
(blocking2.0 final+)
VERIFIED
FIXED
Firefox 4.0
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: iangilman, Assigned: seanedunn)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
When you create a stacked group, resize the group such that the aspect ratio changes, but the group remains stacked. Note that the "expand stack" button moves around with the stack. It should remain centered along the bottom of the group in between the "new tab" button and the resizer mark.
Comment 1•14 years ago
|
||
This, although small, definitely blocks final release.
blocking2.0: --- → ?
Priority: -- → P1
Target Milestone: --- → Firefox 4.0
Reporter | ||
Updated•14 years ago
|
Assignee: nobody → seanedunn
Updated•14 years ago
|
Summary: Expand stack icon moves incorrectly → Expand stack icon moves incorrectly and isn't centered
Comment 2•14 years ago
|
||
I'm worried about the number of blockers we're taking on tab candy, and how they divide into visual polish and functional polish. Speculatively blocking on this, but I'd kick it out of scope in favour of functional blockers, for sure.
blocking2.0: ? → final+
Expand button is now centered under the stack.
Attachment #478857 -
Flags: feedback?(ian)
Reporter | ||
Comment 4•14 years ago
|
||
Comment on attachment 478857 [details] [diff] [review]
v1
Looks good
Attachment #478857 -
Flags: review?(dolske)
Attachment #478857 -
Flags: feedback?(ian)
Attachment #478857 -
Flags: feedback+
Comment 5•14 years ago
|
||
Comment on attachment 478857 [details] [diff] [review]
v1
>+ top: childBB.top + childBB.height - parentBB.top + padding,
>+ left: parentBB.width/2 - this.$expander.width()/2
If the expander is supposed to be fixed on the group rect (at the bottom, centered horizontally), why not use a |bottom| rule, and ignore the childBB entirely?
Updated•14 years ago
|
Status: NEW → ASSIGNED
(In reply to comment #5)
> If the expander is supposed to be fixed on the group rect (at the bottom,
> centered horizontally), why not use a |bottom| rule, and ignore the childBB
> entirely?
Aza wants it centered, hanging under the stack itself.
Updated•14 years ago
|
Attachment #478857 -
Flags: review?(dolske) → review+
Attachment #478857 -
Attachment is obsolete: true
dolske: review+
ian: feedback+
Pushed to try as 10802c9008c7
ready for landing
Attachment #481929 -
Attachment is obsolete: true
Keywords: checkin-needed
Reporter | ||
Comment 10•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/14e4622db30f
Sean, a couple comments on the patch for check in:
* Please list your email address in your user specification (right now it's "Sean Dunn <seanedunn>", should be "Sean Dunn <seanedunn@yahoo.com>").
* The commit message needs an "a=", otherwise mozilla-central rejects it. In this case it would be "a=blocking".
I've fixed it in this case; just for future reference.
Comment 11•14 years ago
|
||
verified with nightly minefield builds of 20101021
expand icon remains centered under the stack
Status: RESOLVED → VERIFIED
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•