Aza Raskin [:aza] Reporter
	Description • 14 years ago

We need to:

* Replace the pencil icon with a monochrome star icon
* Replace the expand icon with our own custom icon (currently it comes from an prefab icon set)

	Michael Yoshitaka Erlewine [:mitcho]
	Comment 1 • 14 years ago

Aza, why do we want to change the pencil to a star? Is the rationale that this is like a "favorite"? I feel like if we keep our current interaction for the pencil icon and change it into a star, however, it could be confusingly different from the favorite star in the URL bar, where clicking the star makes it a favorite, without requiring any additional information from the user.

I'm not adamant about this opinion... I'm just thinking out loud.

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 2 • 14 years ago

Need to get new icons, period.

	Aza Raskin [:aza] Reporter
	Comment 3 • 14 years ago

I went back and double checked, the pencil icon came from Sean Martell. The only one we need to replace is the expand icon.

	Kevin Hanes
	Comment 4 • 14 years ago

Any movement on this? B8 is getting close to shipping and it'd be nice to have.

	Stephen Horlander [:shorlander] Assignee
	Comment 5 • 14 years ago

(In reply to comment #4)
> Any movement on this? B8 is getting close to shipping and it'd be nice to have.

Sorry about that, for some reason I worked on this and never attached it.

I had two ideas for this. One mostly like what we have only different and one with the arrows inside the box.

	Michael Yoshitaka Erlewine [:mitcho]
	Comment 6 • 14 years ago

My vote's for the one inside the box.

Could we position it a tad lower so it hugs the bottom edge, though? Stephen, what do you think?

	Aza Raskin [:aza] Reporter
	Comment 7 • 14 years ago

Agreed, the first of those two icons is beautiful.

Two thoughts:
* We'll need to lower the contrast a fair bit so it doesn't look cluttered in the pre-hover state (a simple CSS thing on our end)
* Does make sense as Mitcho mentions to put the icon lower in the case of the small group

	Stephen Horlander [:shorlander] Assignee
	Comment 8 • 14 years ago

(In reply to comment #7)
> Agreed, the first of those two icons is beautiful.
> 
> Two thoughts:
> * We'll need to lower the contrast a fair bit so it doesn't look cluttered in
> the pre-hover state (a simple CSS thing on our end)

Yeah, it looked like it was currently being done with opacity. I can make two states if needed.

> * Does make sense as Mitcho mentions to put the icon lower in the case of the
> small group

I agree it would look better aligned with the bottom of the new tab icon.

	Stephen Horlander [:shorlander] Assignee
	Comment 9 • 14 years ago

This is the icon png.

	Kevin Hanes
	Comment 10 • 14 years ago

(In reply to comment #9)
> Created attachment 495517 [details]
> Expand Icon - PNG
> 
> This is the icon png.

Hot! Thanks for getting that!

	Aza Raskin [:aza] Reporter
	Comment 11 • 14 years ago

Two states would be lovely. Also, do you think we can use the same icon for all platforms (Linux/Windows/Mac) or do we need to think about distinct visual looks.

	Kevin Hanes
	Comment 12 • 14 years ago

Beta8 has 1 bug left on it, moving our blockers to b9

	Kevin Hanes
	Comment 13 • 14 years ago

bugspam (moving b9 to b10)

	Kevin Hanes
	Comment 14 • 14 years ago

bugspam (removing b9)

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 15 • 14 years ago

This is a hard blocker because we can't ship with the incompatibly licensed image.

	Ian Gilman [:iangilman]
	Comment 16 • 14 years ago

(In reply to comment #11)
> Two states would be lovely. Also, do you think we can use the same icon for all
> platforms (Linux/Windows/Mac) or do we need to think about distinct visual
> looks.

Stephen, do you have a response to this? Should we just go with the single png you have provided, or do you have a hover state and versions for other OSes? Thanks!

	Stephen Horlander [:shorlander] Assignee
	Comment 17 • 14 years ago

(In reply to comment #16)
> (In reply to comment #11)
> > Two states would be lovely. Also, do you think we can use the same icon for all
> > platforms (Linux/Windows/Mac) or do we need to think about distinct visual
> > looks.
> 
> Stephen, do you have a response to this? Should we just go with the single png
> you have provided, or do you have a hover state and versions for other OSes?
> Thanks!

Working on this right now actually :) I am doing platform specific versions with two states.

	Stephen Horlander [:shorlander] Assignee
	Comment 18 • 14 years ago

New Expand Icon

	Stephen Horlander [:shorlander] Assignee
	Comment 19 • 14 years ago

Left to Right: Windows, Linux, Mac

	Michael Yoshitaka Erlewine [:mitcho]
	Comment 20 • 14 years ago

To whoever steps up to implement this: as well as looking at enforcing the correct alignment (comment 8), if you could take a look at bug 625650 in this context as well, that would be great! :D

	Stephen Horlander [:shorlander] Assignee
	Comment 21 • 14 years ago

(In reply to comment #20)
> To whoever steps up to implement this: as well as looking at enforcing the
> correct alignment (comment 8), if you could take a look at bug 625650 in this
> context as well, that would be great! :D

My patch does that. I don't know for sure but it might also fix bug 625650 since it removes the Javascript calculation.

	Dietrich Ayala (:dietrich)
	Comment 22 • 14 years ago

Mitcho, this patch appears to be the implementation. Was there something else that needed to be done?

	Michael Yoshitaka Erlewine [:mitcho]
	Comment 23 • 14 years ago

No, I'm sorry, I didn't realize that his lates upload was actually a patch.

	Ian Gilman [:iangilman]
	Comment 24 • 14 years ago

Comment on attachment 503655 [details] [diff] [review]
New Expand Icon - v01

Looks great! Much better.

Just one detail... I believe the new pngs need to be added to their respective jar.mn files, yes?

R+ with that.

	Stephen Horlander [:shorlander] Assignee
	Comment 25 • 14 years ago

(In reply to comment #24)
> Comment on attachment 503655 [details] [diff] [review]
>
> Just one detail... I believe the new pngs need to be added to their respective
> jar.mn files, yes?

No names changed I just replaced the current file. So the entry would already be in jar.mn

	Michael Yoshitaka Erlewine [:mitcho]
	Comment 26 • 14 years ago

hardblocker = blocker

	Dão Gottwald [:dao]
	Comment 27 • 14 years ago

(In reply to comment #26)
> hardblocker = blocker

blocker = blocks development and/or testing work

See https://bugzilla.mozilla.org/page.cgi?id=fields.html

	Dão Gottwald [:dao]
	Comment 28 • 14 years ago

http://hg.mozilla.org/mozilla-central/rev/8e78ab784c91

	Michael Yoshitaka Erlewine [:mitcho]
	Comment 30 • 14 years ago

(In reply to comment #29)
> Created attachment 504513 [details]
> Tabs don't show in popup. This is what I seen on 17/01 nightly.

This is bug 625443, which was just pushed.

	Tracy Walker [:tracy]
	Comment 31 • 14 years ago

verified with recent minefield nightly build