Closed
Bug 597789
Opened 14 years ago
Closed 13 years ago
--disable-rdf breaks the build
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla10
People
(Reporter: mounir, Assigned: matjk7)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
matjk7
:
review+
|
Details | Diff | Splinter Review |
On current trunk, we can't build with --disable-rdf
|
||
Comment 1•14 years ago
|
||
Moving to build-config, we may as well remove that build option.
Component: RDF → Build Config
QA Contact: rdf → build-config
|
||
Comment 2•14 years ago
|
||
Can we just remove RDF? :) (But yeah, removing the option sounds fine.)
|
||
Comment 3•14 years ago
|
||
XUL still relies on having localstore.rdf for persisting various things, although I'm starting to kill it off in bug 559505. Makes sense to just remove this --footgun until such time as the platform isn't actually needing it.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → matjk7
Status: NEW → ASSIGNED
Flags: in-testsuite-
|
|
Assignee | |
Updated•13 years ago
|
Keywords: dev-doc-needed
|
|
Assignee | |
Comment 4•13 years ago
|
||
Attachment #571483 -
Flags: review?(ted.mielczarek)
|
|
||
Comment 5•13 years ago
|
||
Comment on attachment 571483 [details] [diff] [review]
patch
Review of attachment 571483 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/library/Makefile.in
@@ +106,1 @@
> $(NULL)
Can you change the indent of all three of these blocks while you're here? (To two-space instead of tab.)
Attachment #571483 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
Attachment #571483 -
Attachment is obsolete: true
Attachment #572680 -
Flags: review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 7•13 years ago
|
||
|
|
||
Comment 8•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f0be211721f
(Leaving milestone blank for now, since not sure if it will make today's aurora uplift)
|
|
||
Updated•13 years ago
|
Keywords: checkin-needed
|
|
||
Comment 9•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
|
||
Comment 10•13 years ago
|
||
This option was never documented, but its removal is listed on Firefox 10 for developers.
Keywords: dev-doc-needed → dev-doc-complete
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•