Joe Drew (not getting mail) Reporter
	Description • 14 years ago

When you restore your session, certain tabs aren't loaded immediately (on purpose, thanks to bug 586068). However, these not-yet-loaded tabs permanently have an empty progress bar on them (which fills in and then disappears once it's force loaded by clicking on the tab).

	Paul O'Shannessy [:zpao] (not bugmail, email directly) Assignee
	Comment 1 • 14 years ago

Don't setAttribute("busy", true) until we're actually busy.

	Dietrich Ayala (:dietrich)
	Comment 2 • 14 years ago

Comment on attachment 476851 [details] [diff] [review]
Patch v0.1

r=me

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 3 • 14 years ago

Is it necessary to setAttribute("busy") at all? gotoIndex will trigger that on its own via progress notifications and such, won't it? I imagine we did it before because the natural process might take some time, but that should be less of a problem now that we're not restoring all at once, I hope?

	Johnathan Nightingale [:johnath]
	Comment 4 • 14 years ago

Current behaviour is confusing. Wouldn't hold feature freeze for it, but let's get it in anyhow?

	Paul O'Shannessy [:zpao] (not bugmail, email directly) Assignee
	Comment 5 • 14 years ago

(In reply to comment #3)
> Is it necessary to setAttribute("busy") at all? gotoIndex will trigger that on
> its own via progress notifications and such, won't it? I imagine we did it
> before because the natural process might take some time, but that should be
> less of a problem now that we're not restoring all at once, I hope?

Yea it is set automatically (at least, it works locally). I'm not actually sure of this history behind setting it ourselves. What you imagine sounds reasonable though. I'm fine with taking it out completely. Would you review?

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 6 • 14 years ago

Sure.

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 7 • 14 years ago

Comment on attachment 476851 [details] [diff] [review]
Patch v0.1

(note that it also would have been incorrect to move that line without also moving the call to updateIcon, but bug 597673 makes that point moot)

	Paul O'Shannessy [:zpao] (not bugmail, email directly) Assignee
	Comment 8 • 14 years ago

Just the removal of setAttribute("busy", true);

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 9 • 14 years ago

Important for cascading session restore.

	Paul O'Shannessy [:zpao] (not bugmail, email directly) Assignee
	Comment 10 • 14 years ago

Pushed http://hg.mozilla.org/mozilla-central/rev/a2d25ef0e84d

	u279076
	Comment 11 • 14 years ago

Juan set this as in-litmus? back when we had a progress bar.  Now we use a 2-state spinner.  Juan, do you think this still warrants a testcase?

	juan becerra [:juanb]
	Comment 12 • 14 years ago

If that check isn't part of any related test, I'd like to see one in litmus.

	u279076
	Comment 13 • 14 years ago

Additional check added to existing Litmus test:
https://litmus.mozilla.org/show_test.cgi?id=13860