Closed
Bug 597930
Opened 14 years ago
Closed 14 years ago
Link hover in location bar: some URLs not handled properly because of broken regexp
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 4.0b7
People
(Reporter: GPHemsley, Assigned: adw)
References
()
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
dao
:
review+
dietrich
:
approval2.0+
|
Details | Diff | Splinter Review |
Since the move of the link hover data from the status bar to the location bar, it does not appear that JavaScript URLs are handled properly.
For example, this code:
<a href="javascript:popup('http://www.worldcommunitygrid.org/help/viewTopic.do?shortName=points#177','points',550,650)" class="contentLinkBold">Points<br>Generated</a>
Shows this in the location bar:
http://www.worldcommunitygrid.org/help/viewTopic.do?shortName=points#177','points',550,650)
Notice how the parsing of the href starts at the "http://", instead of the "javascript:", but then swallows up the rest of the JavaScript code, too.
Assignee | ||
Comment 1•14 years ago
|
||
The regexp used to parse the URL is busted. This is embarrassing.
Thanks for filing the bug.
Assignee | ||
Updated•14 years ago
|
Summary: Link hover in location bar: JavaScript URLs not handled properly → Link hover in location bar: some URLs not handled properly because of broken regexp
Updated•14 years ago
|
Attachment #476704 -
Flags: review?(dao) → review+
Comment 2•14 years ago
|
||
We could probably write a simple little test for this so we don't regress it in the future, right?
Assignee | ||
Comment 3•14 years ago
|
||
No code changes, only tests.
Attachment #476704 -
Attachment is obsolete: true
Attachment #476924 -
Flags: review?(dao)
Updated•14 years ago
|
Attachment #476924 -
Flags: review?(dao) → review+
Assignee | ||
Updated•14 years ago
|
Whiteboard: [can land]
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 476924 [details] [diff] [review]
patch with test
Requesting approval2.0, simple one-line fix to a bug, comes with test.
Attachment #476924 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #476924 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
Assignee | ||
Updated•14 years ago
|
Whiteboard: [can land]
Assignee | ||
Comment 6•14 years ago
|
||
Had to back out because I can't land a bug without causing orange.
http://hg.mozilla.org/mozilla-central/rev/9c4a8b86ac0d
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Firefox 4.0b8 → ---
Assignee | ||
Comment 7•14 years ago
|
||
Landed again last night, no orange in nearly 24 hours, calling fixed.
http://hg.mozilla.org/mozilla-central/rev/deb3fe09a0d9
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
http://groups.google.com/group/mozilla.dev.tree-management/browse_thread/thread/9f281275d565657c# says this may have caused substantial memory use regressions on OS X 10.5.
Assignee | ||
Comment 9•14 years ago
|
||
Thanks Kyle. There's no way this bug caused that regression, so I'll comment at the other bug in the push, bug 597338, which is the likelier candidate. (But I don't think it regressed either.)
Updated•14 years ago
|
Target Milestone: Firefox 4.0b8 → Firefox 4.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•