Closed Bug 598417 Opened 14 years ago Closed 14 years ago

Calling remove() on a PopupNotification leaves the icon in the URL bar until page is refocused

Categories

(Toolkit :: General, defect)

Product:
Toolkit
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla2.0b10
Tracking Flags:
Tracking Status
blocking2.0 --- -
status2.0 --- wanted

People

(Reporter: bent.mozilla, Assigned: Gavin)

References

Details

(Whiteboard: [doorhanger])

Attachments

(1 file)

patch
(deleted), patch
mossop
: review+
mossop
: approval2.0+
Details | Diff | Splinter Review
If the browser is in the background with a PopupNotification icon displayed in the URL bar, then remove() is called on the notification from a timer, the icon will stay in the URL bar until I refocus the browser. It then disappears. Found when doing bug 595253.
Attached patch patch (deleted) — — Splinter Review
We were failing to update on removal if the panel wasn't open, which is rather bogus.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #497704 - Flags: review?(dtownsend)
blocking2.0: --- → final+
blocking2.0: final+ → -
Will take the patch, but not serious enough to be a blocker.
status2.0: --- → wanted
Attachment #497704 - Flags: review?(dtownsend)
Attachment #497704 - Flags: review+
Attachment #497704 - Flags: approval2.0+
https://hg.mozilla.org/mozilla-central/rev/93e038700b05 I had to make some further test tweaks because of bug 610130 (mostly removing notifications that previous tests failed to remove, and adjusting test 9's onhidden handlers to ignore the first rather than the second hidden event).
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b10
Whiteboard: [doorhanger]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: