Closed Bug 598619 Opened 14 years ago Closed 14 years ago

Switch-to-tab shouldn't suggest about:blank (closes the current tab if that's blank and switches to random other tab)

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 4.0b8

People

(Reporter: divjot94, Assigned: dao)

References

Details

Attachments

(1 file)

patch
(deleted), patch
asaf
: review+
Gavin
: approval2.0+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:2.0b7pre) Gecko/20100922 Firefox/4.0b7pre Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b7pre) Gecko/20100922 Firefox/4.0b7pre If you starting typing a url which , starts from "ab"... , Awesomebar suggest "about:blank" for "Switch To Tab" , when typed from a blank page , which i don't think is desired. Why would a user type "about:blank" just to get a blank page , or even want to jump to a blank page already opened ? This is my perception , would like UX team to consider this Reproducible: Always Steps to Reproduce: 1.Get a blank page. 2.Type about in awesomebar (url bar) Actual Results: You find about:blank (switch to tab) in the dropdown list
Severity: normal → enhancement
sorry for the typo*
Could be a dupe of bug 558626.
Blocks: switch-to-tab
This is mostly the same as bug 555694 (showing current tab in results). I don't think that we need to special case about:blank - not showing the current tab would fix the majority of the problem
I tend to agree with comment 3. This is not exactly a dupe of bug 555694, but a fix there will resolve this issue. Resolving this as WONTFIX.
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
(In reply to comment #4) > I tend to agree with comment 3. This is not exactly a dupe of bug 555694, but > a fix there will resolve this issue. This dependency can be expressed in bugzilla.
Status: RESOLVED → REOPENED
Depends on: 555694
Ever confirmed: true
Resolution: WONTFIX → ---
On a related note, I'm unable to reproduce this bug. Is it just me or did something else already fix this by now?
(In reply to comment #6) > On a related note, I'm unable to reproduce this bug. Is it just me or did > something else already fix this by now? I'm able to reproduce this quite easily. On Mac: 1. CMD+T 2. Type "about" into awesomebar 3. Select Switch-to-tab result for "about:blank"
Summary: Awesomebar [URL BAR] should not suggest about:blank in "Switch To Tab" when typed from a blank page → Switch-to-tab for about:blank closes new tab, switches to rightmost tab
Updating the summary to reflect the issue more accurately.
Ok, I can reproduce with a different profile. (In reply to comment #3) > This is mostly the same as bug 555694 (showing current tab in results). I don't > think that we need to special case about:blank - not showing the current tab > would fix the majority of the problem However, suggesting about:blank if it's not the current tab doesn't seem helpful either, nor does it actually work (bug 555694 won't solve this).
Severity: enhancement → normal
Status: REOPENED → NEW
No longer depends on: 555694
Attached patch patch (deleted) — — Splinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #488640 - Flags: review?(mano)
Summary: Switch-to-tab for about:blank closes new tab, switches to rightmost tab → Switch-to-tab shouldn't suggest about:blank (closes the current tab if that's blank and switches to random other tab)
Comment on attachment 488640 [details] [diff] [review] patch r=mano
Attachment #488640 - Flags: review?(mano) → review+
Attachment #488640 - Flags: approval2.0?
OS: Windows 7 → All
Hardware: x86 → All
Attachment #488640 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/4a3e2cfe011c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
yay! My first bug got fixed for Firefox 4 :D w00t!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: