Brendan Eich [:brendan] Reporter
	Description • 14 years ago

See bug 571549 comment 19.

Easy to fix, needs fixing. Alan, do you have time to take this bug? If not, push back and someone will take it.

/be

	Alan Pierce
	Comment 1 • 14 years ago

My patch in bug 596988, comment 3 (which was already reviewed, but not pushed) fixes any missing OOM-checking problems in js_ConcatStrings that I'm aware of.

Does this bug refer to that, or something else? I don't see where bug 571549 comment 19 refers to an unchecked OOM.

	Brendan Eich [:brendan] Reporter
	Comment 2 • 14 years ago

(In reply to comment #1)
> My patch in bug 596988, comment 3 (which was already reviewed, but not pushed)
> fixes any missing OOM-checking problems in js_ConcatStrings that I'm aware of.

Whoops, I should have remembered that bug. But you still have else-after-return all over in that patch.

> Does this bug refer to that, or something else? I don't see where bug 571549
> comment 19 refers to an unchecked OOM.

Er, comment 31 was what I meant to reference.

/be