Closed Bug 598823 Opened 14 years ago Closed 14 years ago

Consider backing out bug 518122 if it makes us faster.

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: ehsan.akhgari, Unassigned)

References

Details

(Keywords: perf)

See bug 190147 comment 40 and 43. It may in fact makes us faster if we revert the changes made as part of bug 518122.
OS: Mac OS X → All
Hardware: x86 → All
Not appending would regress textarea.value+= badly, I thin And we need StringBeginsWith for appending. I'm about to test this.
So if I comment out the code bug 518122 added, the testcase for bug 190147 (1000 iterations) goes up from the current 0.4 to 1.88.
And the testcase for bug 518122, from 564ms to 1542ms
Marking wontfix, but feel free to reopen if you think there is still some reason to consider backing out bug 518122.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
(In reply to comment #4) > Marking wontfix, but feel free to reopen if you think there is still > some reason to consider backing out bug 518122. Just to check my sanity, you did test this on a tree with the patches to bug 240933, right?
I tested m-c today.
(In reply to comment #6) > I tested m-c today. OK, thanks a lot for investigating this. I concur with the WONTFIX decision here.
You need to log in before you can comment on or make changes to this bug.