File: firefox/testPasswordManager/testPasswordNotSaved.js This test module consists of two tests: * testPasswordNotificationBar() * testPasswordNotSaved() These should be split into two separate test modules. I recommend moving testPasswordNotificationBar() to its own module.

Move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.

Vlad, that's one of the tests we have to split out.

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/13242923

Comment on attachment 531617 [details] [diff] [review] Patch v1.0 Review of attachment 531617 [details] [diff] [review]: -----------------------------------------------------------------

Comment on attachment 531617 [details] [diff] [review] Patch v1.0 Review of attachment 531617 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine to me -- tested ok on Mac. r+ Over to Henrik for additional review.

Comment on attachment 531617 [details] [diff] [review] Patch v1.0 Thanks for the patch Vlad. There are only some small things we should do. >+++ b/tests/functional/testPasswordManager/testPasswordNotificationBar.js Wed May 11 16:27:12 2011 +0300 >+ * Portions created by the Initial Developer are Copyright (C) 2009 Please use 2011 here. The PasswordNotSaved test doesn't use the locationbar class, so we can remove the inclusion of the lib and any other trace. Also please delete the comments for the litmus meta data, those are simply wrong and we don't use them anymore. Thanks.

Comment on attachment 531911 [details] [diff] [review] Patch v1.1 Looks fine. Only one nit, please export the patch the next time so it already contains your user information. See our documentation how to do that.

Landed as: http://hg.mozilla.org/qa/mozmill-tests/rev/792ecdd366ad (default) http://hg.mozilla.org/qa/mozmill-tests/rev/61ec80bc191c (aurora)

Vlad, can you also please update the Litmus tests if not done yet?

This test covers https://litmus.mozilla.org/show_test.cgi?id=15983. Marking as fixed.

Also test https://litmus.mozilla.org/show_test.cgi?id=15639

Also pushed to beta: http://hg.mozilla.org/qa/mozmill-tests/rev/2609a3b841bb