Closed
Bug 599190
Opened 14 years ago
Closed 14 years ago
cfx testcfx fails if package doesn't have README.md
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: myk, Unassigned)
Details
Attachments
(1 file)
(deleted),
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
package-spec.md says "A package may optionally contain a [Markdown]-formatted file called `README.md` in its root directory. Package-browsing tools may display this file to developers."
But |cfx testcfx| fails a test if a package doesn't have an README.md file:
--------------------------------------------------------------------------------
(jsdk)myk@myk:~/Projects/jsdk$ cfx testcfx
...................................E.........................
======================================================================
ERROR: test_generate_static_docs_does_not_smoke (cuddlefish.tests.test_server.ServerTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/myk/Projects/jsdk/python-lib/cuddlefish/tests/test_server.py", line 12, in test_generate_static_docs_does_not_smoke
server.generate_static_docs(env_root, tgz_filename=filename)
File "/home/myk/Projects/jsdk/python-lib/cuddlefish/server.py", line 407, in generate_static_docs
os.path.join(dest_dir, "README.md"))
File "/usr/lib/python2.6/shutil.py", line 52, in copyfile
fsrc = open(src, 'rb')
IOError: [Errno 2] No such file or directory: '/home/myk/Projects/jsdk/packages/goup-key/README.md'
----------------------------------------------------------------------
Ran 61 tests in 2.286s
FAILED (errors=1)
--------------------------------------------------------------------------------
That test shouldn't fail, or package-spec.md should state that README.md is required. Presumably the former, since there doesn't seem to be a reason why a README.md file would be required. But Atul will know more.
Atul: what was the intention regarding README.md files?
Comment 1•14 years ago
|
||
Comment 2•14 years ago
|
||
Comment on attachment 479155 [details] [diff] [review]
patch
Good point, sorry about that. I think this patch fixes it.
Attachment #479155 -
Flags: review?(myk)
Reporter | ||
Comment 3•14 years ago
|
||
Comment on attachment 479155 [details] [diff] [review]
patch
It does indeed.
Attachment #479155 -
Flags: review?(myk) → review+
Comment 4•14 years ago
|
||
Pushed:
Bug 599190 - cfx testcfx fails if package doesn't have README.md
Atul Varma [:atul]
http://hg.mozilla.org/labs/jetpack-sdk/rev/2b8f57ce01e6
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•14 years ago
|
||
The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.
To filter bugmail related to this change, filter on the word "looptid".
Component: Jetpack SDK → General
Product: Mozilla Labs → Add-on SDK
QA Contact: jetpack-sdk → general
You need to log in
before you can comment on or make changes to this bug.
Description
•