Closed Bug 599503 Opened 14 years ago Closed 14 years ago

Return the true compartment info for getCompartment()

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Version:
Other Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- beta7+

People

(Reporter: gal, Assigned: gal)

References

Details

(Whiteboard: [compartments])

Attachments

(2 files)

patch
(deleted), patch
jorendorff
: review+
Details | Diff | Splinter Review
patch
(deleted), patch
gal
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch patch (deleted) — — Splinter Review
Assignee: general → gal
Attached patch patch (deleted) — — Splinter Review
This should also work. We don't need the JSObject::getCompartment indirection.
Attachment #478551 - Flags: review+
Gregor, can you test this? I was seeing weird test failures. Is everything out of the default compartment yet?
Yeah I saw some test failures on linux64 debug and win debug. Looking...(In reply to comment #3) > Gregor, can you test this? I was seeing weird test failures. Is everything out > of the default compartment yet? Yeah I saw some test failures on linux64 debug and win debug. Looking...
Thanks.
Whiteboard: [compartments]
Please note that we have now created a branch for beta 7 work. In addition to landing your fix on mozilla-central default, please also land it on mozilla-central GECKO20b7pre_20101006_RELBRANCH (note: when landing on mozilla-central default, you will be given priority in the landing queue at https://wiki.mozilla.org/LandingQueue )
http://hg.mozilla.org/mozilla-central/rev/47429cecc9cb
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
No longer blocks: 584860
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: