Closed
Bug 599628
Opened 14 years ago
Closed 14 years ago
[SeaMonkey] mochitests-1/5: "TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_bug561636.html | Test timed out."
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
VERIFIED
FIXED
mozilla2.0b7
People
(Reporter: bugzilla, Assigned: mounir)
References
(Blocks 1 open bug, )
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
(deleted),
patch
|
Callek
:
feedback+
|
Details | Diff | Splinter Review |
Probably the result from bug 599258. We don't even get to the first check in that test, so the hang occurs somewhere else.
Comment 1•14 years ago
|
||
Does this fail locally, and if so can you check if there are any existing observers for invalidformsubmit registered. [I don't see how] But this test shouldn't call |waitForExplicitFinish| if there are no observers and thus shouldn't time out.
Updated•14 years ago
|
Whiteboard: [orange]
Updated•14 years ago
|
Blocks: SmTestFail
Assignee | ||
Comment 2•14 years ago
|
||
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #478592 -
Flags: review?(bugspam.Callek)
Assignee | ||
Comment 3•14 years ago
|
||
The test is run when onload is called. waitForExplicitFinish should have been called before. I don't see how that might break SeaMonkey but that was a mistake. So, now finish() is explicitly call if there is no observer.
Comment 4•14 years ago
|
||
Comment on attachment 478592 [details] [diff] [review] Patch v1 Unable to test locally right now, so feedback+ If you want an official review before being willing to push this, re-request and I'll be sure to do just that [with local testing]. code-inspection-wise this looks good though.
Attachment #478592 -
Flags: review?(bugspam.Callek) → feedback+
Comment 5•14 years ago
|
||
Interesting... I didn't fail this locally.... :/
Reporter | ||
Comment 6•14 years ago
|
||
The test hang for me and passes with the patch. So looks good.
Updated•14 years ago
|
Component: Testing Infrastructure → DOM: Core & HTML
Product: SeaMonkey → Core
QA Contact: testing-infrastructure → general
Updated•14 years ago
|
Summary: TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_bug561636.html | Test timed out. → [SeaMonkey] mochitests-1/5: "TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_bug561636.html | Test timed out."
Assignee | ||
Comment 7•14 years ago
|
||
Justin, according to comment 5, you were able to test this. May I have you r+? :)
Comment 8•14 years ago
|
||
(In reply to comment #7) > Justin, according to comment 5, you were able to test this. May I have you r+? > :) c#5 was about with_out_ this patch, I didn't fail locally.... but r+ anyway based on Aqualon's c#6
Assignee | ||
Comment 9•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d0d3ac2ce08c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
Comment 10•14 years ago
|
||
(In reply to comment #9) > http://hg.mozilla.org/mozilla-central/rev/d0d3ac2ce08c 1.32 + if (!observers.hasMoreElements()) { Nit: adding an explicit todo(false, ...) or ok(true, ...) would be perfect. 1.33 + SimpleTest.finish(); 1.34 + return; 1.35 + }
Assignee | ||
Comment 11•14 years ago
|
||
The current mochitest behavior is to add a todo if there is no test. Isn't that enough?
Comment 12•14 years ago
|
||
(In reply to comment #11) > The current mochitest behavior is to add a todo if there is no test. Isn't that > enough? Yes it is. And I have not seen this on any runs of the test for SeaMonkey machines since this landed--> Verified
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•