Closed
Bug 599827
Opened 14 years ago
Closed 14 years ago
tabbrowser-alltabs-popup should hide over-link when an about:blank menuitem is active
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 4.0b7
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
dao
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
For about:blank tabs, tabbrowser-alltabs-popup sets the over-link to a single space, which "cleared" the status bar when the over-link used to be shown there. But since the over-link is now shown in the location bar, a single space causes the over-link to appear as a single space. setOverLink should now be passed a falsey value to hide the over-link instead.
(Or setOverLink could trim the string it's passed. Or we could just show "about:blank" like we do for about:home, about:addons, etc.)
Attachment #478740 -
Flags: review?(gavin.sharp)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 478740 [details] [diff] [review]
patch
> if (tab) {
>+ var overLink = tab.linkedBrowser.currentURI.spec;
nit: let
>+ if (overLink == "about:blank")
>+ overLink = null;
>+ XULBrowserWindow.setOverLink(overLink, null);
The first argument is supposed to be a string.
Attachment #478740 -
Flags: review?(gavin.sharp) → review-
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #478740 -
Attachment is obsolete: true
Attachment #479006 -
Flags: review?(dao)
|
|
||
Updated•14 years ago
|
Attachment #479006 -
Flags: review?(dao) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 479006 [details] [diff] [review]
patch 2
Requesting approval2.0, simple low-risk fix.
Attachment #479006 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #479006 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
|
|
||
Updated•14 years ago
|
Target Milestone: Firefox 4.0b8 → Firefox 4.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•