Closed Bug 600029 Opened 14 years ago Closed 14 years ago

Running ts_cold_generated_* tests on windows and should not

Categories

(Testing :: Talos, defect)

Product:
Testing
Component:
Talos
Platform:
All
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sdwilsh, Assigned: anodelman)

References

Details

Attachments

(1 file)

[checked in] do not run any of the cold tests on windows
(deleted), patch
lsblakk
: review+
Details | Diff | Splinter Review
We are running the ts_cold_generated_* tests on windows, but we shouldn't since we have no way to clear the cache. On the plus side, this means we get more talos time given back to the pool :)
This was an oversite when the dirty tests were initially created.
Component: Release Engineering → Talos
Product: mozilla.org → Testing
QA Contact: release → talos
Version: other → unspecified
Assignee: nobody → anodelman
Comment on attachment 478875 [details] [diff] [review] [checked in] do not run any of the cold tests on windows >-BRANCHES['mozilla-central']['cold_tests'] = (1, True, {}, NO_WIN) >+BRANCHES['mozilla-central']['cold_tests'] = (1, True, TALOS_DIRTY_OPTS, NO_WIN) Was this tested? I don't understand why all the cold_tests now have TALOS_DIRTY_OPTS passed in.
Comment on attachment 478875 [details] [diff] [review] [checked in] do not run any of the cold tests on windows looks good.
Attachment #478875 - Flags: review?(lsblakk) → review+
Cleared up with lsblakk that we need the dirty profile options as these are dirty+cold tests, so they need the generated profiles to test against.
This landed, and I no longer see any cold builders for Windows.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 478875 [details] [diff] [review] [checked in] do not run any of the cold tests on windows Landed in 883c318795a2
Attachment #478875 - Attachment description: do not run any of the cold tests on windows → [checked in] do not run any of the cold tests on windows
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: