Closed
Bug 600328
Opened 14 years ago
Closed 14 years ago
1.9.1 and 1.9.2 talos on tiger is orange
Categories
(Testing :: Talos, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nthomas, Assigned: nthomas)
References
Details
Attachments
(1 file)
(deleted),
patch
|
anodelman
:
review+
|
Details | Diff | Splinter Review |
From bug 599961 comment #2:
> The fail in talos will be a regression from the talos change in bug 598507. The
> buildbot logs have
> *error: arch takes no arguments
> Probably should farm that out to another bug, and possibly just change the
> check to |platform.mac_ver()[0][:4] == '10.5'|.
arch on Tiger is just a reporting tool for architecture type, rather than a launcher like on *Leopard.
Comment 1•14 years ago
|
||
So, only run the arch command on leopard?
Assignee | ||
Comment 2•14 years ago
|
||
talos-rev2-tiger10:~ mozqa$ python
Python 2.4.4 (#1, Oct 18 2006, 10:34:39)
[GCC 4.0.1 (Apple Computer, Inc. build 5341)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import platform
>>> platform.mac_ver()[0][:4] == '10.5'
False
talos-r3-leopard-010:~ cltbld$ python
Python 2.5.1 (r251:54863, Jun 17 2009, 20:37:34)
[GCC 4.0.1 (Apple Inc. build 5465)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import platform
>>> platform.mac_ver()[0][:4] == '10.5'
True
talos-r3-snow-010:~ cltbld$ python
Python 2.5.4 (r254:67916, Jul 7 2009, 23:51:24)
[GCC 4.2.1 (Apple Inc. build 5646)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import platform
>>> platform.mac_ver()[0][:4] == '10.5'
False
Which is correct - we don't use Tiger for anything more modern than 1.9.1 or 1.9.2, so they aren't affected by the change to the m-c universal build.
Attachment #479151 -
Flags: review?(anodelman)
Comment 3•14 years ago
|
||
Comment on attachment 479151 [details] [diff] [review]
Only use arch on Leopard
This will need to land in both cvs and hg talos.
Attachment #479151 -
Flags: review?(anodelman) → review+
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 479151 [details] [diff] [review]
Only use arch on Leopard
Checking in ffprocess_mac.py;
/cvsroot/mozilla/testing/performance/talos/ffprocess_mac.py,v <-- ffprocess_mac.py
new revision: 1.21; previous revision: 1.20
done
http://hg.mozilla.org/build/talos/rev/bd373f708dce
Assignee | ||
Comment 5•14 years ago
|
||
Also updated http://build.mozilla.org/talos/zips/talos.zip for the two changes I've landed.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•