Andreas Gal :gal Reporter
	Description • 14 years ago

+++ This bug was initially created as a clone of Bug #600173 +++

See bug 558861 comment 76

	Andreas Gal :gal Reporter
	Comment 2 • 14 years ago

The current code might not take advantage of ATOM_NOCOPY in all cases. This patch will fix that.

	Igor Bukanov Assignee
	Comment 3 • 14 years ago

This fixes the wrongful unlocking and adds better comments. Note even with that the patch has passed the try server.

	Gregor Wagner [:gwagner]
	Comment 4 • 14 years ago

(In reply to comment #3)
> Created attachment 479453 [details] [diff] [review]
> v2
> 
> This fixes the wrongful unlocking and adds better comments. Note even with that
> the patch has passed the try server.

Well it's a race condition...

	Igor Bukanov Assignee
	Comment 5 • 14 years ago

The patch passes the try server.

	Andreas Gal :gal Reporter
	Comment 6 • 14 years ago

The patch contains a race condition which will lead to data corruption and crashes. Why are we even discussing this? Please look at the code. You cannot allocate from the default compartment without holding the atom state lock. Period. There is no allocation locking any more and multiple threads access the free list _of the default compartment_ (only).

	Igor Bukanov Assignee
	Comment 7 • 14 years ago

(In reply to comment #6)
> The patch contains a race condition which will lead to data corruption and
> crashes.

The new version fixes that - see the comment 3.

	Andreas Gal :gal Reporter
	Comment 8 • 14 years ago

Ok, lets dup my bug against this one then and land it (or invalidate the other, either way).

	Igor Bukanov Assignee
	Comment 9 • 14 years ago

http://hg.mozilla.org/tracemonkey/rev/d425cdb7d074

	Robert Sayre
	Comment 11 • 14 years ago

http://hg.mozilla.org/mozilla-central/rev/d425cdb7d074