Closed
Bug 600734
Opened 14 years ago
Closed 14 years ago
TM: some jstracer.h clean-ups
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
(deleted),
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
Some jstracer.h clean-ups:
- Don't #include jstracer.h into .cpp files that don't need it. jstracer.h is
not #included into any .h files, so I'm confident it's not being pulled in
transitively anywhere.
- Remove some dead declarations.
- Move the tprint() stuff into the private part of TraceRecorder, it doesn't
need to be public.
Attachment #479626 -
Flags: review?(gal)
|
||
Updated•14 years ago
|
OS: Mac OS X → Windows 7
|
Assignee | |
Updated•14 years ago
|
Attachment #479626 -
Flags: review?(gal) → review?(dmandelin)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 479626 [details] [diff] [review]
patch (against TM 54637:835980f51185)
Backout analysis, as an exercise: I can't see how this could possibly need to back out in a beta stage, since it just moves code around or deletes things--if it builds, it is correct. (It could be backed out easily, too, which is probably true of all can't-fail patches.)
Attachment #479626 -
Flags: review?(dmandelin) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
The '#include "jstracer.h"' ended up slightly different -- some files that didn't need it before now do, but I also found some more that had it but didn't need it.
http://hg.mozilla.org/tracemonkey/rev/513774b1e88e
OS: Windows 7 → All
Hardware: x86 → All
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•