Closed
Bug 600993
Opened 14 years ago
Closed 14 years ago
tab sync no longer has any reason to ever touch disk
Categories
(Firefox :: Sync, defect)
Tracking
()
RESOLVED
FIXED
1.6
Tracking | Status | |
---|---|---|
blocking2.0 | --- | betaN+ |
People
(Reporter: mconnor, Assigned: philikon)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
We can recreate data from the sessionstore API if needed, and bug 600991 should mean that for most users the ordering data is entirely irrelevant, so we can just sync all tabs, in the order of the window. We should just special-case tabs to keep a score, but not changedIDs, and grab the current tab set when it's time to sync, and make sure it never saves JSON to disk.
Reporter | ||
Updated•14 years ago
|
blocking2.0: --- → betaN+
Assignee | ||
Comment 1•14 years ago
|
||
(In reply to comment #0)
> We can recreate data from the sessionstore API if needed, and bug 600991 should
> mean that for most users the ordering data is entirely irrelevant, so we can
> just sync all tabs, in the order of the window.
I'm not sure what that has to do with disk I/O.
> We should just special-case
> tabs to keep a score, but not changedIDs, and grab the current tab set when
> it's time to sync, and make sure it never saves JSON to disk.
Indeed. Patch coming up!
Assignee | ||
Comment 2•14 years ago
|
||
Assignee: nobody → philipp
Attachment #489409 -
Flags: review?(mconnor)
Reporter | ||
Comment 3•14 years ago
|
||
Comment on attachment 489409 [details] [diff] [review]
v1
This works, though I'm waffling on .modified as a "public" value. Either way works, it's not like it's really public/not public.
Attachment #489409 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Whiteboard: [qa-]
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•