Closed Bug 601092 Opened 14 years ago Closed 14 years ago

Remove AdBlock workaround from RTL intl.css [ar, fa, he]

Categories

(Mozilla Localizations :: he / Hebrew, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tomer, Unassigned)

References

()

Details

Attachments

(1 file)

The current intl.css is a mess, and it's about time to remove some old entries from that file. The file is duplicated between few locales, and we will need to update it on all these locales. The first step is to get rid of AdBlock rule to force its preferences window to LTR. AdBlock addon [http://adblock.mozdev.org] is dead for long time now, and AdBlock Plus doesn't have this element ID at all. Affected locales: ar, fa, he http://mxr.mozilla.org/l10n-central/search?string=adblockPreferencesWindow&find=intl.css&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-central
Attachment #480072 - Flags: review?(l10n)
Comment on attachment 480072 [details] [diff] [review] Removing AdBlock workaround and removing some commented out code (Hebrew only for now) I can't really say anything but "yay" for less of that. Whether that works, no idea. I'd suggest that you get reviews from people that actually use that code, like ehsan or Anas.
Attachment #480072 - Flags: review?(l10n)
No one is actually using that code, as the latest AdBlock release was on 2003, and officially supported Firefox 1.0.7. I don't think there is anyone out there that is using that addon with recent Firefox versions, and that element ID is used only be Adblock addon afaik. Ehsan (cc'ed, as you've done most of the recent clean ups) - What is your suggestion?
Comment on attachment 480072 [details] [diff] [review] Removing AdBlock workaround and removing some commented out code (Hebrew only for now) SHIP IT! :)
Attachment #480072 - Flags: review+
Also, Tomer, I think you've missed the Firefox case, see http://hg.mozilla.org/l10n-central/fa/rev/8a40f844da8e
I pushed this change to all fa branches!
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: