Closed
Bug 601092
Opened 14 years ago
Closed 14 years ago
Remove AdBlock workaround from RTL intl.css [ar, fa, he]
Categories
(Mozilla Localizations :: he / Hebrew, defect)
Mozilla Localizations
he / Hebrew
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tomer, Unassigned)
References
()
Details
Attachments
(1 file)
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
The current intl.css is a mess, and it's about time to remove some old entries from that file. The file is duplicated between few locales, and we will need to update it on all these locales.
The first step is to get rid of AdBlock rule to force its preferences window to LTR. AdBlock addon [http://adblock.mozdev.org] is dead for long time now, and AdBlock Plus doesn't have this element ID at all.
Affected locales: ar, fa, he
http://mxr.mozilla.org/l10n-central/search?string=adblockPreferencesWindow&find=intl.css&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-central
Attachment #480072 -
Flags: review?(l10n)
Comment 1•14 years ago
|
||
Comment on attachment 480072 [details] [diff] [review]
Removing AdBlock workaround and removing some commented out code (Hebrew only for now)
I can't really say anything but "yay" for less of that.
Whether that works, no idea. I'd suggest that you get reviews from people that actually use that code, like ehsan or Anas.
Attachment #480072 -
Flags: review?(l10n)
Reporter | ||
Comment 2•14 years ago
|
||
No one is actually using that code, as the latest AdBlock release was on 2003, and officially supported Firefox 1.0.7. I don't think there is anyone out there that is using that addon with recent Firefox versions, and that element ID is used only be Adblock addon afaik.
Ehsan (cc'ed, as you've done most of the recent clean ups) - What is your suggestion?
Comment 3•14 years ago
|
||
Comment on attachment 480072 [details] [diff] [review]
Removing AdBlock workaround and removing some commented out code (Hebrew only for now)
SHIP IT! :)
Attachment #480072 -
Flags: review+
Comment 4•14 years ago
|
||
Also, Tomer, I think you've missed the Firefox case, see http://hg.mozilla.org/l10n-central/fa/rev/8a40f844da8e
Comment 5•14 years ago
|
||
I pushed this change to all fa branches!
Reporter | ||
Comment 6•14 years ago
|
||
Committed as 69179223eb61.
http://hg.mozilla.org/l10n-central/he/rev/69179223eb61
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•