Closed
Bug 601255
Opened 14 years ago
Closed 14 years ago
Hide the Private Browsing jumplist entry when inside permanent PB mode
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 4.0b7
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
It doesn't make any sense for us to show the option to quit PB mode in the jumplist menu if the permanent PB mode is active (see also bug 601253).
|
Assignee | |
Comment 1•14 years ago
|
||
We support turning on the PB mode from within the preferences UI, so I think this should block 4.0 (especially since that it's a really easy fix).
blocking2.0: --- → ?
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #480298 -
Flags: review?(dolske)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 480298 [details] [diff] [review]
Patch (v1)
Wasn't sure if the open() change made sense, but I see we already disable Tools -> Stop Private Browsing when in permanent PB mode, so it's consistent with that.
Attachment #480298 -
Flags: review?(dolske) → review+
|
|
||
Updated•14 years ago
|
blocking2.0: ? → final+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs landing]
|
||
Updated•14 years ago
|
Flags: in-litmus?
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → Firefox 4.0b8
|
||
Updated•14 years ago
|
Target Milestone: Firefox 4.0b8 → Firefox 4.0b7
|
||
Comment 5•14 years ago
|
||
Current latest-trunk always shows "Enter private browsing" entry in jumplist when permanent PM mode is enabled. Is that ok? Is that a regression?
When firefox is closed and I select that entry, firefox will not open. Otherwise (when firefox is already open) nothing happens.
You need to log in
before you can comment on or make changes to this bug.
Description
•